feat(ui-banner): add Banner component (WIP) - #2713
Open
adamlobler wants to merge 2 commits into
Open
adamlobler wants to merge 2 commits into
adamlobler wants to merge 2 commits into
Conversation
Adds a new promotional Banner component built on tokens already registered in instructure-design-tokens across all four themes. Supports violet/sea colors, relaxed/compact density, an optional dismiss control, an optional header and decorative icon slot, and primary/secondary action slots. Wires the component into the ui umbrella package (v11_7 export) and adds a regression-test page and Cypress spec entry. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
v1.5.0 predates the Banner component's tokens, so ui-banner's build:types failed in CI with "Property 'Banner' does not exist on type 'ComponentTypes'". v1.8.0 includes Banner's tokens across all four themes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
Contributor
Visual regression reportCypress suite: ❌ Failing — see the run logs. Visual diff:
Accessibility (axe):
📊 View full report — click a screenshot's ⚠ badge to see each violation boxed on the image, with the offending element named and contrast failures shown as color swatches. Diff images (3)badge-canvas.png — 1573 pixels differcalendar-canvas.png — 478 pixels differtooltip-dark.png — 881 pixels differBaselines come from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new promotional Banner component built on tokens already registered in instructure-design-tokens across all four themes. Supports violet/sea colors, relaxed/compact density, an optional dismiss control, an optional header and decorative icon slot, and primary/secondary action slots.
Wires the component into the ui umbrella package (v11_7 export) and adds a regression-test page and Cypress spec entry.
🤖 Generated with Claude Code