feat: added support for @platformatic/kafka - #2751
Merged
Merged
Conversation
Contributor
Author
|
waiting for nodejs/import-in-the-middle#290 |
abhilash-sivan
force-pushed
the
feat-platformatic-kafka
branch
from
September 23, 2026 10:50
5bb4d8d to
750843b
Compare
abhilash-sivan
marked this pull request as ready for review
September 23, 2026 12:56
kirrg001
reviewed
Sep 23, 2026
| * the entry otel span will contain our Instana trace and parent information, which we have to | ||
| * extract and connect to our Instana spans to keep the correlation. | ||
| */ | ||
| module.exports.extractW3CTraceContext = (preparedData, otelSpan) => { |
Contributor
There was a problem hiding this comment.
We can add add a shared instrumentation helper later. No prio for now
kirrg001
reviewed
Sep 23, 2026
kirrg001
previously approved these changes
Sep 23, 2026
kirrg001
left a comment
kirrg001
left a comment
Contributor
There was a problem hiding this comment.
Unblocking. One comment is important.
kirrg001
previously approved these changes
Sep 23, 2026
abhilash-sivan
enabled auto-merge (squash)
September 23, 2026 13:21
aryamohanan
reviewed
Sep 23, 2026
| } | ||
|
|
||
| // node bin/start-test-containers.js --zookeeper --kafka --kafka-topics | ||
| // Note: @platformatic/kafka is ESM-only. Run tests with RUN_ESM=true. |
Contributor
There was a problem hiding this comment.
qs: Why this condition here? I think you have to add this in currency.json.
aryamohanan
reviewed
Sep 23, 2026
aryamohanan
previously approved these changes
Sep 23, 2026
abhilash-sivan
force-pushed
the
feat-platformatic-kafka
branch
from
September 23, 2026 14:32
e23ee5d to
ab414cd
Compare
abhilash-sivan
disabled auto-merge
September 23, 2026 14:33
abhilash-sivan
enabled auto-merge (squash)
September 23, 2026 14:33
aryamohanan
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-113473
Summary
Adds OpenTelemetry-based tracing instrumentation for
@platformatic/kafkausing@platformatic/kafka-opentelemetry.It maps producer operations as exit spans and consumer process operations as entry spans while handling W3C trace context propagation and span transformation into Instana spans.
Action plan:
Test results:
https://instana.rocks/s/KT_xjECIRZ6-Cq7Re6oeJg