Repository navigation
Increase test coverage - #268
Conversation
|
✅ All contributors have signed the CLA |
Code Coverage SummaryDiff against mainResults for commit: b9c9eb4 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 7 suites 9s ⏱️ Results for commit edec383. ♻️ This comment has been updated with latest results. |
|
I have read the CLA Document and I hereby sign the CLA |
osenan
left a comment
There was a problem hiding this comment.
Hi,
Thanks for the big PR! We already reached the goal of coverage but we need to make further changes.
I would modify the .lintr and remove the pipe linter. In my opinion, the pipes can be native pipes for the tests and magritr pipes for the package.
Please see the comments on the file. We need refactor in the tests that are using internal functions. There are specific suggestions mentioned in many files.
osenan
left a comment
There was a problem hiding this comment.
Thanks! Now is much better. Please address the comments and fix the checks, which should be simple, lintrs and change the DESCRIPTION.
|
Let's open a new issue for the lintr issues. There are many and most of them refer to using the magrittr pipe instead of base R one. This requires a discussion if upgrading the R version is acceptable. |
Pull Request
Closes https://github.com/insightsengineering/coredev-tasks/issues/802
Adds tests to the package.
In addition I fixed two warnings related to
tidyselect(select(all_of())) andggplot2(aes_()toaes()and an argument partial match onseq(lenght)toseq(length.out).