Conversation
…o "Positron Agent" - Remove Zone computation (Inventory venue + venue-abbreviation/GAM-name fallback, including its instance-renaming side effect) from Endpoint/Device.ToMetricData. Zone is left empty for now pending a redesign of how it should be sourced. - Remove the venue-abbreviation lookup subsystem from devicelookup (VenueAbbrLookup type, Load/Save/Refresh/IsVenueAbbrLookupStale, ZoneFor/ZoneForWithFallback/AbbreviationCandidate) and the now-unused DeviceInfo.Venue field. - Stop maintaining/refreshing the venue-abbreviation cache in the worker. - Fix ComponentName to a single constant, "Positron Agent", for every instance (endpoints and devices alike), replacing the previous per-record Positron-Endpoint/Positron-GAM heuristic. - Remove the now-unused endpoint_component_name/gam_component_name config options. - Update tests and README to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed zone/subvenue enrichment and per-record component naming from positron-agent so metric instances now always report a fixed identity.
Positron endpoint and device metrics previously derived a "Zone" from the Device Inventory's venue field, with a fallback heuristic that matched venue-abbreviation prefixes in device names (and, for endpoints, fell back to the parent GAM's name) — this fallback also had a side effect of renaming instances by prepending the resolved abbreviation. That entire mechanism has been removed: Zone is no longer computed and is left empty on every metric for now, pending a future redesign of how it should be sourced. The supporting venue-abbreviation lookup (loading/refreshing/caching venue_abbreviations.json, and the ZoneFor/ZoneForWithFallback resolution logic) has been deleted from the devicelookup package, and the worker no longer maintains or refreshes that cache.
Component naming has also been simplified: instead of picking "Positron-Endpoint" vs "Positron-GAM" per record based on model type/product class/name heuristics, every instance (both endpoints and devices) now reports a single fixed component name, "Positron Agent". The related endpoint_component_name/gam_component_name config options have been removed since they're no longer used.
These changes reduce risk from a heuristic that could mis-tag zones/names and simplify the data model while we settle on the right long-term approach for zone metadata. No other metric fields (instance name, display name, IP) were affected. Config, tests, and README have been updated to match the new behavior.