Repository navigation
Update Go to 1.27 and dependencies - #176
Conversation
This comment has been minimized.
This comment has been minimized.
Use Go 1.27 for the container builder and refresh the checkout action. Keep the hub-mirror action pinned to master. Select the target platform for the runtime image so arm64 releases include an arm64 base. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
Update Kubernetes clients, cloud SDK dependencies and vendored modules. Keep kube-openapi at v0.0.0-20260721132016-d427ff9ee9ad: newer revisions return structured-merge-diff/v7 schema types, incompatible with Kubernetes v0.37.1 using v6. Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
1ba261b to
7cfc074
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
7cfc074 to
d2680d9
Compare
AI Pull Request OverviewDisclaimer: This review was generated by automated AI and may contain errors. Do not trust its outputs without human verification. Summary
Approval rating (1-10)6/10. Dependency metadata is coherent, but the final Dockerfile defeats the stated arm64 runtime-base correction and should be fixed before merge. Summary per fileSummary per file
Overall AssessmentThe dependency and workflow refresh is internally consistent, and the new commit messages contain no prohibited AI attribution. However, the final Dockerfile reintroduces the exact multi-platform base-image problem the first commit intended to solve. Tagged arm64 builds will select the builder host's runtime base rather than the arm64 runtime base, so the PR should not merge until that regression is corrected. Detailed ReviewDetailed Review
|
Description
Update the container builder to Go 1.27 and refresh checkout and hub-mirror actions to released versions. Use the target platform for the runtime base image so arm64 releases contain an arm64 base.
Update Kubernetes clients to v0.37.1, go-password to v0.4.0 and transitive cloud SDK dependencies, with refreshed vendoring. Keep kube-openapi at
v0.0.0-20260721132016-d427ff9ee9ad: newer revisions return structured-merge-diff/v7 schema types that do not compile with Kubernetes v0.37.1's v6 types.How Has This Been Tested?
On Linux amd64 with Go 1.27.3:
go test ./...,go vet ./...andgo mod verifypassed.docker buildx build --platform linux/amd64,linux/arm64 --build-arg Version=dev --build-arg GitCommit=<commit> --output type=oci,dest=/tmp/inlets-operator-validation.oci.tar .. Both platforms passed the Dockerfile unit tests and license check, then produced release binaries and images. Arm64 unit tests executed through QEMU/binfmt emulation.linux/amd64andlinux/arm64, both running asnonroot:nonroot. Extracted binaries are stripped, statically linked x86-64 and AArch64 ELF files respectively;--helpsmoke checks passed for both (arm64 under emulation).FROM/ascasing warnings.How are existing users impacted? What migration steps/scripts do we need?
No configuration migration is required. Building from source requires Go 1.27.
Checklist:
I have:
git commit -s