Skip to content

feat: add PHP 7.4 typehints, set PHP 7.4 as minimal supported PHP ver… - #178

Open
Roman3349 wants to merge 1 commit into
influxdata:masterfrom
Roman3349:feature/php7.4
Open

feat: add PHP 7.4 typehints, set PHP 7.4 as minimal supported PHP ver…#178
Roman3349 wants to merge 1 commit into
influxdata:masterfrom
Roman3349:feature/php7.4

Conversation

@Roman3349

Copy link
Copy Markdown
Contributor

Proposed Changes

Added PHP 7.4 typehints, fixed most of issues reported by PHPStan, set PHP 7.4 as minimal supported PHP version.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • make test completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

…sion

Signed-off-by: Roman Ondráček <mail@romanondracek.cz>
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.09804% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.81%. Comparing base (d0029dc) to head (ec1e576).

Files with missing lines Patch % Lines
src/InfluxDB2/ClientOptionsUdp.php 56.75% 16 Missing ⚠️
src/InfluxDB2/UdpWriter.php 21.42% 11 Missing ⚠️
src/InfluxDB2/ClientOptions.php 91.37% 5 Missing ⚠️
src/InfluxDB2/DefaultApi.php 87.50% 3 Missing ⚠️
src/InfluxDB2/Client.php 87.50% 1 Missing ⚠️
src/InfluxDB2/FluxCsvParser.php 97.77% 1 Missing ⚠️
src/InfluxDB2/WriteApi.php 95.83% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #178      +/-   ##
============================================
+ Coverage     74.86%   78.81%   +3.94%     
+ Complexity      461      450      -11     
============================================
  Files            25       27       +2     
  Lines          1110     1147      +37     
============================================
+ Hits            831      904      +73     
+ Misses          279      243      -36     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants