Request for a better way to handle exceptions thrown from State class's execution methods

[tcascio]

I think it would be nice to have a generic way to handle exceptions thrown from State class's execution methods (like a controller advice in Spring).

[mixydubs]

Hi @tcascio, @longquanzheng and I were reviewing this ticket and we have some concerns about a feature like this:

• increased learning curve for future users
• hidden "magic"

Are you thinking of something like @NotRetriableException = RuntimeException

[longquanzheng]

Looks like "exception handler" for the whole workflow, like in Spring controller.

Technically this is possible.
At this moment, you should do it per state. It's pure Java code, you should be able to find a way to abstract and minimize the code duplication:

class BaseStateWithExceptionHandler : WorkflowState {

  override StateDecision execute(...){
      try{
         return doExecute(...);
      }catch (e: NonRetryableException){ 
         return StateDecision.singleNextState(ErrorHandleState.class, ...);
      }
  }

  abstract StateDecision doExecute(...); // each state must implement this 
}

Then each state will just:

class MyState:BaseStateWithExceptionHandler {
  override  StateDecision doExecute(...){
       // your state logic
  }
}