Conversation
Rua
force-pushed
the
make_cast-no-withstmts
branch
8 times, most recently
from
September 15, 2026 19:12
53ee966 to
9874c82
Compare
Rua
force-pushed
the
make_cast-no-withstmts
branch
from
September 15, 2026 19:19
9874c82 to
87e2433
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The only thing here that actually required a
WithStmtsspecifically was an assert for theNullToPointercase. That case was throwing out the existingWithStmtsand replacing it with a new one, resulting in a double translation.NullToPointeris never returned byCastKind::from_types, and so that path is only ever hit when being called fromconvert_cast. So I just movedNullToPointerthere instead.