postprocess: fix configuration and filtering papercuts - #1996
Open
thedataking wants to merge 6 commits into
Open
thedataking wants to merge 6 commits into
thedataking wants to merge 6 commits into
Conversation
Mixed absolute and relative source/exclude arguments could raise ValueError before processing any functions. Resolve both sides before matching, and union whole identifiers for equivalent YAML paths. Cover path combinations, entries outside the exclude directory, and equivalent entries without splitting identifiers into characters.
Generation rechecked provider environment variables after model selection, silently skipping CRISP endpoints and clients constructed with an explicit API key. Use the selected cache-only mock to decide whether generation is available. Exercise retries with a configured fake model that needs no provider environment variable.
json.loads raises json.JSONDecodeError, not the requests exception. Catch the correct exception so malformed compile_commands.json files receive the intended path-specific error. This also removes an undeclared requests import.
The CLI uses the model interface independently of comment transfer. Import it from the models package instead of relying on an incidental import in the comments transform.
Delete commented-out model and validator interface sketches, along with TODOs for model and cache options that already exist. Active interfaces and behavior are unchanged.
The filter selects matching identifiers for processing; the README incorrectly described matches as excluded.
thedataking
force-pushed
the
perl/postprocess-cleanup
branch
from
September 7, 2026 03:39
c42d3be to
f7cbb5e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First in the stack; followed by #1997.
Fix independent postprocessor papercuts, one per commit:
Prompts and cache keys are unchanged.
Validation: 60 tests passed; four tests requiring a local c2rust binary skipped. Ruff format, Ruff lint, and ty passed. No live model calls.