Flt 28 1차 qa 박찬미 - #220
Merged
Hidden character warning
The head ref may contain hidden characters: "FLT-28-1\ucc28-qa-\ubc15\ucc2c\ubbf8"
Merged
Conversation
- footer copyright 문단 없애기
…to FLT-28-1차-qa-박찬미 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Contributor
|
Warning Review limit reached
Next review available in: 39 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough컬렉션 생성 화면이 Android 시스템 포토 피커의 단일·다중 선택을 지원합니다. 이미지 수를 최대 5개로 제한합니다. 컬렉션 상세 화면은 nullable 썸네일과 고정 상단 앱 바를 지원합니다. 썸네일과 콘텐츠 이미지의 표시 비율 및 그라데이션을 변경했습니다. Changes컬렉션 미디어 흐름
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)포토 피커 이미지 선택sequenceDiagram
participant CollectionCreateScreen
participant AndroidPhotoPicker
participant CollectionCreateViewModel
CollectionCreateScreen->>AndroidPhotoPicker: 남은 슬롯 수로 선택 요청
AndroidPhotoPicker-->>CollectionCreateScreen: URI 목록 반환
CollectionCreateScreen->>CollectionCreateViewModel: addContentImageUris 호출
CollectionCreateViewModel-->>CollectionCreateScreen: 최대 5개 이미지 상태 반영
컬렉션 상세 화면 표시sequenceDiagram
participant CollectionDetailScreen
participant LazyColumn
participant CollectionDetailThumbnail
participant CollectionDetailTopAppBar
CollectionDetailScreen->>LazyColumn: 썸네일과 콘텐츠 목록 구성
LazyColumn->>CollectionDetailThumbnail: nullable thumbnailUrl 전달
CollectionDetailScreen->>CollectionDetailTopAppBar: 고정 앱 바 동작 연결
CollectionDetailThumbnail-->>LazyColumn: 기본 이미지 또는 네트워크 이미지 렌더링
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@app/src/main/java/com/flint/presentation/collectioncreate/CollectionCreateScreen.kt`:
- Around line 141-150: Update the image-selection callback around
pendingMaxSelectable so that when its value is 0, display a toast and exit
before checking permissions or opening the gallery picker. Preserve the existing
permission and picker flow when at least one image remains selectable.
In
`@app/src/main/java/com/flint/presentation/collectiondetail/component/CollectionCopyrightFooter.kt`:
- Line 18: Remove the CollectionCopyrightFooter() invocation from
CollectionDetailScreen so the copyright footer is no longer displayed. If
CollectionCopyrightFooter has no remaining usages, delete the component and its
associated file or declarations as well.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ca951c88-5fae-4ed3-8084-0a3acfaebcc4
📒 Files selected for processing (14)
app/src/main/AndroidManifest.xmlapp/src/main/java/com/flint/core/designsystem/theme/Color.ktapp/src/main/java/com/flint/data/dto/collection/response/CollectionDetailResponseDto.ktapp/src/main/java/com/flint/domain/model/collection/CollectionDetailModel.ktapp/src/main/java/com/flint/presentation/collectioncreate/CollectionCreateScreen.ktapp/src/main/java/com/flint/presentation/collectioncreate/CollectionCreateViewModel.ktapp/src/main/java/com/flint/presentation/collectioncreate/component/CollectionCreateContentImage.ktapp/src/main/java/com/flint/presentation/collectioncreate/component/CollectionCreateThumbnail.ktapp/src/main/java/com/flint/presentation/collectioncreate/component/GalleryImagePickerDialog.ktapp/src/main/java/com/flint/presentation/collectioncreate/navigation/CollectionCreateNavigation.ktapp/src/main/java/com/flint/presentation/collectiondetail/CollectionDetailScreen.ktapp/src/main/java/com/flint/presentation/collectiondetail/component/CollectionCopyrightFooter.ktapp/src/main/java/com/flint/presentation/collectiondetail/component/CollectionDetailContent.ktapp/src/main/java/com/flint/presentation/collectiondetail/component/CollectionDetailThumbnail.kt
MediaStore를 직접 조회하던 커스텀 갤러리 다이얼로그를 제거하고 PickMultipleVisualMedia로 교체해 최대 5장 제한을 OS가 강제하도록 함. - maxItems는 1이면 크래시하므로 남은 자리 수에 따라 분기 (0장 토스트 / 1장 단일 선택 / 2~5장 다중 선택) - 포토피커는 권한이 불필요하므로 READ_MEDIA_IMAGES, READ_EXTERNAL_STORAGE 및 권한 요청 코드 제거 - 시스템 피커는 선택 상태를 미리 지정할 수 없어 setContentImageUris를 addContentImageUris(추가 방식)로 변경 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
kimjw2003
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
📌 작업 내용
📸 스크린샷
😅 미구현
🫛 To. 리뷰어
Summary by CodeRabbit
새로운 기능
개선 사항