Repository navigation
Cover the remaining API parameters and fields - #94
Merged
Merged
Conversation
New *WithOptions variants for copy, move, delete, restore, the trash list, last uploaded and public resources, and upload by URL, adding overwrite, force_async, md5, filters, sorting and previews. The existing methods call them and do not change. Disk, User, Resource and Exif gain the fields the API returns, including those lost in v1.1.0. GPS coordinates use a Coordinate type that tolerates the empty object the API schema allows, so an odd value cannot fail a whole listing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Checked against the API schema, these were missing. All additions;
nothing existing changes.
force_async
monthly traffic limit, upgrades, registration time and more
and Exif GPS
GPS coordinates use a Coordinate type: the schema leaves their type
open and the API sandbox returns {}, which would otherwise fail the
whole resource.
Checked locally
Tests for every new parameter and field; go vet, go test ./... (also
as 386), golangci-lint v2.13.2; yad builds and passes its tests
against this branch.