Repository navigation
Send the parameters the API documents - #93
Merged
Merged
Conversation
Three requests did not match the API reference:
- DeleteResource sent permanent=true, which the API ignores, so a
permanent delete went to the trash. It now sends permanently.
- Uploads asked for overwrite with an X-Overwrite header the API does
not know, so uploading over an existing file failed with 409. The
upload link request now carries overwrite, through the new
GetLinkForUploadWithOverwrite.
- OperationStatus asked for operations?operation_id=, while the
operation ID belongs in the path: operations/{id}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Checked against the API schema and reference, three requests did not
match. Each was silently wrong:
yad hits the last two: re-uploading a file, and following a move.
What
the X-Overwrite header is gone. GetLinkForUpload is unchanged.
Checked locally
Tests for each; they fail on the old code. go vet, go test ./... (also
as 386), golangci-lint v2.13.2.