Repository navigation
Treat 204 and 202 from a delete as success - #91
Merged
Merged
Conversation
The API answers 204 once a resource is deleted, and 202 when a large folder is deleted in the background, but DeleteResource accepted only 200. Every successful delete came back as "request failed with status 204", in yad as an error message after the file was already gone. Batch deletes go through the same method and are fixed too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DeleteResource accepted only 200, while the API answers 204 when the
resource is gone and 202 when a large folder is deleted in the
background. Every successful delete returned an error, after the file
had already been deleted. Batch deletes use the same method.
What
the 204 and 202 cases fail with "request failed with status 204".
Checked locally
go vet, go test ./... (also as 386), golangci-lint v2.13.2.