Repository navigation
Decode sizes and revisions as int64 - #89
Merged
Merged
Conversation
As int they overflowed on 32-bit systems: a Disk or a file over 2 GB, or any revision (a microsecond timestamp), failed to decode, so even DiskInfo returned an error on 386 and 32-bit ARM. Resource.Size, Resource.Revision and Disk.TotalSpace, UsedSpace, TrashSize, MaxFileSize and Revision are now int64. Code that stores one of them in an int needs a conversion; the README shows how. CI now runs the tests as 386 too. BREAKING CHANGE: the fields above changed type from int to int64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On 32-bit systems int is 32 bits wide. Disk sizes, file sizes over 2 GB
and every revision (a microsecond timestamp) overflowed it, so decoding
failed and even DiskInfo returned an error on 386 and 32-bit ARM. yad
needs this before it can ship builds for those platforms.
What
TrashSize, MaxFileSize and Revision are now int64.
Compatibility
Code that keeps one of these fields in an int stops compiling and needs
int(...) or an int64 variable. The compiler points at each spot.
Checked locally
go vet on amd64 and 386, go test ./... on amd64 and 386,
golangci-lint v2.13.2, markdownlint.