feat: add scatter-gather design pattern #3577 - #3590
Conversation
PR SummaryIntroduced the Scatter-Gather module with core components, tests, and documentation to run multiple tasks concurrently, gather responses within a timeout, and aggregate results. Changes
autogenerated by presubmit.ai |
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Files Processed (12)
- pom.xml (1 hunk)
- scatter-gather/README.md (1 hunk)
- scatter-gather/etc/scatter-gather-pattern.png (0 hunks)
- scatter-gather/pom.xml (1 hunk)
- scatter-gather/src/main/java/com/iluwatar/scattergather/Aggregator.java (1 hunk)
- scatter-gather/src/main/java/com/iluwatar/scattergather/AirlineService.java (1 hunk)
- scatter-gather/src/main/java/com/iluwatar/scattergather/App.java (1 hunk)
- scatter-gather/src/main/java/com/iluwatar/scattergather/ScatterGatherExecutor.java (1 hunk)
- scatter-gather/src/main/java/com/iluwatar/scattergather/TaskSupplier.java (1 hunk)
- scatter-gather/src/test/java/com/iluwatar/scattergather/AggregatorTest.java (1 hunk)
- scatter-gather/src/test/java/com/iluwatar/scattergather/AirlineServiceTest.java (1 hunk)
- scatter-gather/src/test/java/com/iluwatar/scattergather/ScatterGatherExecutorTest.java (1 hunk)
Actionable Comments (0)
Skipped Comments (5)
-
scatter-gather/src/main/java/com/iluwatar/scattergather/ScatterGatherExecutor.java [58-58]
best_practice: "Replace toList() with Collectors.toList() for compatibility"
-
scatter-gather/src/main/java/com/iluwatar/scattergather/ScatterGatherExecutor.java [36-36]
best_practice: "Add missing import for Collectors"
-
scatter-gather/src/main/java/com/iluwatar/scattergather/TaskSupplier.java [32-32]
readability: "Javadoc formatting"
-
scatter-gather/src/main/java/com/iluwatar/scattergather/TaskSupplier.java [34-34]
readability: "Typo in Javadoc"
-
scatter-gather/pom.xml [46-49]
best_practice: "Add junit-jupiter-api test dependency"
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3590 +/- ##
============================================
+ Coverage 83.79% 83.93% +0.13%
- Complexity 4277 4288 +11
============================================
Files 1121 1124 +3
Lines 15144 15168 +24
Branches 723 725 +2
============================================
+ Hits 12690 12731 +41
+ Misses 2159 2139 -20
- Partials 295 298 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| * THE SOFTWARE. | ||
| */ |
There was a problem hiding this comment.
App.java seems to be empty. Usually we have here the main entry point of the program. You should supply commentary about the pattern and its implementation as well.
There was a problem hiding this comment.
See also that it has certain level of logging so that execution can traced.
There was a problem hiding this comment.
✅ LGTM!
Review Summary
Commits Considered (1)
- 00bf897: Merge branch 'master' into feature/scatter-gather
Files Processed (1)
- pom.xml (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
-
pom.xml [216-216]
enhancement: "Add new Maven module to multimodule build."
Pull Request Template
What does this PR do?