Skip to content

fix(install): resolve install shadowing, test slicing, security guards, and tool exposure (#424, #439, #440, #441, #442) - #443

Merged
ils15 merged 2 commits into
mainfrom
fix/smoke-and-install-shadowing
Nov 14, 2026
Merged

ils15 merged 2 commits into
mainfrom
fix/smoke-and-install-shadowing

Conversation

@ils15

@ils15 ils15 commented Nov 14, 2026

Copy link
Copy Markdown
Owner

Summary

This PR resolves all outstanding issues discovered during smoke verification and reported across issues #424, #439, #440, #441, and #442:

  1. Global Install Shadowing & PATH Hygiene (Fixes install: stale global copies across npm prefixes cause PATH shadowing and version skew #424):

    • Added Doctor check (H2b) to detect multiple global binary copies, dangling symlinks, and PATH prefix skew across npm prefixes.
    • Added explicit version skew validation in resolveStablePantheonRoot preventing _npx from silently binding to older global packages.
    • Cleansed npm_config_allow_scripts and npm_config_approve_scripts in sync-tui.mjs to avoid EALLOWSCRIPTS errors during nested npm ci.
  2. Strict Test Slice Filter Ordering (Fixes Bug: test:slice --failed-only emits --test-name-pattern after file path (Node ignores filter) #442):

    • Reordered --test-name-pattern flag ahead of the test file path in scripts/test-slice.mjs so Node's native test runner filters tests during failure/fix loops.
  3. Repository Internal & Traversal Exclusion in Permissions and Guards (Fixes Security: auto-permissions read/glob branch and zeusReadGuard do not enforce .git/node_modules exclusion #441):

    • Enforced deterministic path checks in auto-permissions.ts and zeusReadGuard denying .git/**, node_modules/**, and path traversal escaping cwd.
  4. Universal Session Todo Tool Availability (Fixes Bug/Gap: todowrite/todoread tools not exposed to root Zeus agent #439):

    • Granted todowrite and todoread across all 14 specialist agent manifests in src/agents/roster.json and registered tool capabilities in scripts/install/capabilities.mjs.
  5. Session Auto-Discovery for Zen Vision (Fixes Bug: vision_describe requires active OpenCode session id not resolvable from root Zeus #440):

    • Automated OpenCode session ID resolution from environment (OPENCODE_SESSION_ID) and SQLite opencode.db (session_v2) for vision_describe, resolving orchestration vision calls cleanly.
  6. Documentation & Roadmap:

    • Updated ROADMAP.md with 2.1.4 deliveries and CHANGELOG.md with closed issues.

Verification

iris added 2 commits November 14, 2026 13:48
…s, and tool exposure (#424, #439, #440, #441, #442)

- Detect and warn on PATH shadowing and prefix skew in doctor H2b check (#424)
- Validate version alignment in resolveStablePantheonRoot before binding global candidate (#424)
- Sanitize npm_config_allow_scripts in sync-tui.mjs to avoid EALLOWSCRIPTS (#424)
- Reorder --test-name-pattern ahead of file path in test-slice.mjs (#442)
- Enforce .git and node_modules path denial in auto-permissions and zeusReadGuard (#441)
- Expose todowrite and todoread across all 14 agents in roster.json and capabilities (#439)
- Auto-discover active session ID for vision_describe from environment or opencode.db (#440)
- Update ROADMAP.md and CHANGELOG.md
@ils15
ils15 merged commit 10418c7 into main Nov 14, 2026
10 checks passed
@ils15
ils15 deleted the fix/smoke-and-install-shadowing branch November 14, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment