[PDO] Bound-check column index in getColumnMeta() - #301
Open
iliaal wants to merge 1 commit into
Open
Conversation
getColumnMeta() indexed stmt->columns[colno] as soon as the driver get_column_meta hook reported success, without verifying that columns had been described or that colno was below column_count, so a driver returning unconditional success made an unexecuted statement segfault and an oversized index read out of bounds. Reject both cases with ValueError like the fetch paths do. Sibling audit: all other stmt->columns[] sites are inside describe_columns() loops or bound-checked paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PDOStatement::getColumnMeta() indexed stmt->columns[colno] as soon as the driver get_column_meta hook reported success, without checking that columns had been described or that colno was below column_count, so a driver returning unconditional success (e.g. pdo_odbc) segfaulted on an unexecuted statement and read out of bounds for an oversized index. The patch rejects both cases with ValueError like the fetch paths do, keeping the existing bool(false) behavior of drivers that report failure themselves. Sibling audit found all other stmt->columns[] accesses inside describe_columns() loops or bound-checked paths.