[DOM] Register id attributes set via setAttribute() in XML documents - #298
Open
iliaal wants to merge 1 commit into
Open
[DOM] Register id attributes set via setAttribute() in XML documents#298iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
getElementById() relies on the XML_ATTRIBUTE_ID flag that only the HTML registration path used to set for dynamically created attributes, leaving Dom\XMLDocument::getElementById() blind to ids set through setAttribute(), setAttributeNS() and setAttributeNode(). Drop the document-type restriction so modern XML documents register a namespaced-less id attribute like HTML documents already do; setIdAttribute(false) still unregisters. Siblings audited: all three dom_check_register_attribute_id() call sites (setAttribute, setAttributeNode(NS), setAttributeNS) plus php_set_attribute_id()/ setIdAttribute* which already handled both directions. which already handled both directions.
iliaal
force-pushed
the
fix/dom-setattribute-id-master
branch
from
August 26, 2026 12:56
5f9a6b6 to
c47910e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getElementById() only found dynamically created id attributes in HTML documents because the registration helper restricted the XML_ATTRIBUTE_ID flag to XML_HTML_DOCUMENT_NODE, so Dom\XMLDocument::getElementById() returned null after setAttribute("id", ...) though the id property had registered. The restriction is dropped so modern XML documents register an un-namespaced id attribute, setIdAttribute(false) still unregisters, and legacy DOMDocument stays unchanged because every helper call site sits behind spec mode. A phpt covers set, re-set, setAttributeNS, removal and setIdAttribute(false).