[PDO] Fail nextRowset() when pdo_stmt_describe_columns() fails - #284
Open
iliaal wants to merge 1 commit into
Open
[PDO] Fail nextRowset() when pdo_stmt_describe_columns() fails#284iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
pdo_stmt_do_next_rowset() ignored the return value of pdo_stmt_describe_columns(), so a driver describer failure after a successful rowset advance left partially initialized columns[] while nextRowset() still returned true; subsequent fetches would then touch incomplete column state. The result is now checked and the method returns false on failure, consistent with all other call sites (pdo_stmt_do_execute(), pdo_stmt_do_fetch(), PDO::prepare()) which already check it. No runtime reproducible case exists among bundled drivers, hence no test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pdo_stmt_do_next_rowset() ignored the return value of pdo_stmt_describe_columns(), so if a driver describer failed after a successful rowset advance, nextRowset() still returned true while columns[] was left partially initialized and later fetches or getColumnMeta() would touch incomplete column state; this is a code-inspection-level latent defect with no runtime-reproducible case among bundled drivers, hence no test. The fix checks the describe result and returns false from nextRowset(), matching every other call site of pdo_stmt_describe_columns() (pdo_stmt_do_execute(), pdo_stmt_do_fetch(), PDO::prepare()) which already check it; sibling audit found no other unchecked call.