[PDO] Return false from rewrite_name_to_position() on IM001 error path - #283
Open
iliaal wants to merge 1 commit into
Open
[PDO] Return false from rewrite_name_to_position() on IM001 error path#283iliaal wants to merge 1 commit into
iliaal wants to merge 1 commit into
Conversation
rewrite_name_to_position() returns bool, so the previous -1 was converted to true and the caller's failure check at pdo_stmt.c:328 never triggered after raising the IM001 error for a repeated named parameter. Sibling audit: no other -1 return remains in this function; the other error paths already return 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rewrite_name_to_position() is declared bool, so the -1 returned after raising the IM001 error for a repeated :named parameter was converted to true and the caller's failure check in dispatch_param_event() never saw the failure. This changes the return to false so the error propagates correctly. Sibling audit found no other -1 return in this function or its call sites.