[PDO] Do not register bindColumn() binding after exception - #277
Open
iliaal wants to merge 1 commit into
Open
Conversation
When ERRMODE_EXCEPTION is set, really_register_bound_param() raised the impl error for an unknown column name but continued registering the binding into bound_columns, so repeated failing bindColumn() calls with distinct names grew the hash without bound. Abort registration when an exception is pending; bindValue()/bindParam() take the is_param path and are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ERRMODE_EXCEPTION is set, really_register_bound_param() raised the implementation error for an unknown column name but kept going and registered the binding in bound_columns anyway, so repeated failing bindColumn() calls with distinct names grew the hash without bound (about 33 MB over 200k calls). The fix aborts registration as soon as an exception is pending after pdo_raise_impl_error(); bindValue() and bindParam() take the is_param path where this mapping block is skipped, so they are unaffected. A new .phpt reproduces the growth before the patch and asserts no leak after.