Feat: FFT-based self-gravity solver - #398
Open
glesur wants to merge 5 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new FFT-based solver for the Poisson equation as an alternative to the existing iterative solvers.
Implementation
The new module is built on Kokkos-fft, which is added as a submodule alongside Kokkos. It also requires an external FFT library (e.g. FFTW on CPU) to build. The feature is enabled via the Idefix_FFT CMake option.
Limitations
MPI domain decomposition is only supported along X3.
Only cartesian domains with periodic boundary conditions are supported.
Acknowledgements
The parallel FFT class and transposition code are adapted from the implementation in Astra.