Bug: Coarsening+Viscosity - #397
Open
glesur wants to merge 2 commits into
Open
Conversation
…n coarsening is enabled.
There was a problem hiding this comment.
Pull request overview
Fixes viscous velocity-gradient computations when grid coarsening is enabled by applying coarsening-aware effective cell spacing before forming derivatives/stress terms.
Changes:
- Introduce per-cell effective
dx1/dx2/dx3inViscosity::AddViscousFluxand scale them by the local coarsening factor. - Use the corrected spacings consistently across IDIR/JDIR/KDIR sweeps for gradient, divergence, and stress-tensor terms.
Suppressed comments (1)
src/fluid/viscosity.cpp:464
dx3is computed unconditionally but only used whenDIMENSIONS == 3in this sweep. In 2D builds this can produce an unused-variable warning. Mark it[[maybe_unused]]to keep builds warning-clean.
real dx1 = dx1Array(i);
real dx2 = dx2Array(j);
real dx3 = dx3Array(k);
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+213
to
+215
| real dx1 = dx1Array(i); | ||
| real dx2 = dx2Array(j); | ||
| real dx3 = dx3Array(k); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the computation of velocity gradients in the viscosity module when coarsening is enabled.