Repository navigation
[patch] Pass db2u_kind to mas-update PipelineRun (MASISMIG-79074) - #526
Open
ankit-bhadoriya wants to merge 1 commit into
Open
ankit-bhadoriya wants to merge 1 commit into
ankit-bhadoriya wants to merge 1 commit into
Conversation
The pipelinerun-update template did not emit db2u_kind, so the mas-update pipeline could never forward it to the mas-devops-db2 task. For existing Db2uInstance deployments the db2 role then defaulted to db2ucluster and failed with DB2U_KIND MISMATCH DETECTED during the Db2 v11 to v12 upgrade. Render db2u_kind inside the Db2 update block when it is provided, matching how pipelinerun-install already handles it. Omitted when empty so existing callers are unaffected.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
pipelinerun-update.yml.j2template did not emit thedb2u_kindparameter,so even though the CLI correctly detected the deployment type and set
db2u_kind,the value was silently dropped before reaching the
mas-devops-db2task. The Ansiblerole then defaulted to
db2uclusterand failed withDB2U_KIND MISMATCH DETECTED!on environments using existing
Db2uInstancedeployments.Root Cause
pipelinerun-update.yml.j2had no block to renderdb2u_kindinto the PipelineRunparams.
pipelinerun-install.yml.j2already handles it correctly — this brings theupdate template to parity.
Changes
src/mas/devops/templates/pipelinerun-update.yml.j2— renderdb2u_kindinsidethe Db2 update block when provided, omit when empty (safe for existing callers)
test/src/test_tekton_update.py— 4 new unit tests forlaunchUpdatePipeline():db2u_kind=db2uinstanceis rendered into PipelineRun paramsdb2u_kind=db2uclusteris rendered into PipelineRun paramsdb2u_kindis omitted when not provided (existing callers unaffected)db2u_kindis omitted when empty stringTesting
test_tekton_update.py)Db2uInstanceon v11.5.9.0, updated tov9-260902-amd64(Db2 v12). With this fix applied,
update-db2task passed successfully and Db2upgraded to v12.
Related
ibm-mas/cli: branchmasismig-79074