OSD chip driver? - #11944
Draft
sensei-hacker wants to merge 12 commits into
Draft
OSD chip driver?#11944sensei-hacker wants to merge 12 commits into
sensei-hacker wants to merge 12 commits into
Conversation
MS7456--On-screen display (OSD) generator
Create a folder named "ms7456" for the monochrome On-Screen Display (OSD) generator,
Delete
Release/9.1 to master
The size-diff bot's "RAM Δ" summed every writable memory region into one figure, so a PR that only grew CCM (or DTCM) usage looked identical to one that grew main RAM by the same amount - misleading on parts where those regions have very different remaining headroom (e.g. reported +3,740 B for MATEKF405 when the RAM region itself only grew 608 B, the rest was CCM). extract-size-report.sh now also computes each target's per-region usage from its .map file (matching arm-none-eabi-size -A section addresses against the linker's own memory map, no per-family section-name table needed) and size-diff-comment.js renders regions separately when both the PR and baseline reports have them, falling back to the old combined figure otherwise so existing stored baselines keep working. Also split the shared 256 B notability threshold into separate flash (4096 B) and RAM (1024 B, applied per-region) thresholds - the old single threshold was too tight for flash's much larger budget and flagged nearly every PR.
Flare only activates when a healthy rangefinder is present (see getHwRangefinderStatus() gate in navigation.c); on GPS-only aircraft the landing silently stays in the glide phase all the way to touchdown, producing a consistent overshoot in height and distance that no other autoland tuning parameter can fix. This wasn't documented anywhere users would see it while tuning nav_fw_land_flare_alt/pitch, only in a separate wiki-style doc, so add it to the settings descriptions directly. Fixes iNavFlight#11751
…inal-glideslope Document rangefinder requirement for FW autoland flare phase
Contributor
|
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing |
Code Review by QodoNo Changes in PRQodo reviewed your PR and found no changes in the codeTip of the day💡 Did you know, you can ask Qodo to dismiss a finding you disagree with, with your reason on record |
sensei-hacker
marked this pull request as draft
September 14, 2026 03:42
The addr == 0 filter meant to skip unallocated debug/symbol metadata also caught .tcm_code, since F7/H7 place ITCM_RAM at ORIGIN 0x0 and link that FAST_CODE section there. Detect allocation via objdump -h's ALLOC flag instead of address, which is the only way to tell a real zero-origin section apart from metadata that's never actually placed. Verified against a real AOCODARCF722AIO build: the old filter silently dropped its 11192-byte ITCM_RAM usage from the region breakdown entirely; the fix reports it correctly alongside TCM and RAM.
…ta-per-region-reporting Report CI size-diff RAM delta per linker region, not combined
Release/9.1 to master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisting @HeYongYan97 with adding a driver for their OSD chip.