Repository navigation
fix: folder matching, preview, progress and download-speed follow-ups from the Mac report - #123
Merged
Merged
Conversation
…ow external drives From a tester's report of a Mac sorting run that ended with files missing, an unclear result and an external drive that could not be used. File loss - handleDuplicateMove compared a file against files the same run had still to move. Two byte-identical files renamed or moved in one run were each taken for a copy already in place, both went to the trash, the move check failed and the run was undone with the two files gone. A file the run has still to move no longer counts as a copy in place, and a rename inside one folder never removes the file. Move outcomes - A run that did not move everything stays on Organize with a banner: how many moved, how many did not and why, or that the run was undone. - Identical copies that were removed are listed as duplicates with the copy that was kept, and are no longer counted as moved. Sources that are also destinations - A notice on Organize and a mark in Preview say which files stay where they are, or are only renamed there. External drives - A folder outside the user folder can be a Smart Folder, can be scanned and can have folders created in it. sanitizeFolderPath no longer bounds paths to the home tree; the destination policy decides, and asks once for a folder that is not inside a Smart Folder or Documents and was not picked in a dialog. - Still refused: system folders and links into them, startup folders, device paths and traversal. LINK_OUTSIDE_ALLOWED becomes LINK_INTO_SYSTEM; ALLOWED_APP_PATHS is removed. - A refused or unreadable folder on Discover gives the reason instead of "No files found". Not changed: one file failing the move check still undoes the whole run. Not verified: macOS, and a packaged build of this branch.
… from the Mac report Folder matching - A category counts as a misspelling of a Smart Folder name only within an allowance that grows with the name's length (none under four characters, one per four, three at most). A fixed allowance of two sent "SEO" to "Web". - A generic category with no Uncategorized folder returns no match instead of the first folder in the list. - A strategy suggestion's explanation says what named its folder (category, file type or purpose) instead of the template's title. - The analysis cache key uses each Smart Folder's whole description, not its first 64 characters. Organize preview - handlePreviewOrganize throws when the dry run fails or is refused, and returns the files the batch sends to one name. The Organize screen shows the reason, shows the button as working and ignores a second press. - The preview marks same-name files and keeps Move off while any exist. Discover - Analysis progress reads "Analyzing 3 of 10 files" and "30% complete", with the percentage once. - The notice for an analysis that continues after a restart says so. Model download - Speed and time left are the rate over the last ten seconds, reported once three seconds of data exist. The wizard row reads "Calculating speed…" until then. Docs - The Install Guide, README and release notes say which Mac file to take for Apple Silicon and for Intel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the hands-on Mac report: items 7, 8, 11, 12, 14 and 15. Stacked on #122, so this PR also shows #122's commit (4b8dd95) until that one merges. The new work is the single commit c53ee4c.
What changes
Folder matching (items 7 and 8)
Organize preview (item 12)
handlePreviewOrganizethrows when the dry run fails or is refused and returns the files the batch sends to one name. No main-process change.Discover (item 11)
Model download (item 15)
Docs (item 14)
release.ymlsay which Mac file to take (mac-arm64for Apple Silicon,mac-x64for Intel) and how to check in About This Mac.Not in this PR
Checks
Windows 11 x64, on c53ee4c's tree:
npm run local:gate, every step: 956 test suites, 14126 tests passed, 11 skipped, coverage thresholds met, production build, native modules.The eight Playwright smoke specs on a clean dev build: 101 of 101.
The new release-notes line from
release.yml, run by hand in Windows PowerShell 5.1 with a sample version: one list entry with both file names filled in. The workflow file still parses as YAML.Not checked: macOS, a packaged build, and the release workflow itself (it runs only in a release, under PowerShell 7).