feat(api)!: sync generated SDK from staging (removes google_calendar + slack list endpoints)#99
feat(api)!: sync generated SDK from staging (removes google_calendar + slack list endpoints)#99aburkard wants to merge 1 commit into
Conversation
|
Firetiger has created a monitoring plan for this PR. |
| if echo "$UPLOAD_RESPONSE" | grep -q "HTTP/[0-9.]* 200"; then | ||
| echo -e "\033[32mUploaded build to Stainless storage.\033[0m" | ||
| echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk/$SHA'\033[0m" | ||
| echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk-staging/$SHA'\033[0m" |
There was a problem hiding this comment.
Success message points to staging install URL in production repo
The artifact is uploaded via $SIGNED_URL (production-signed), but the printed install URL references node-sdk-staging instead of node-sdk. A developer following this output would install the staging package, not the artifact just uploaded to production storage.
| echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk-staging/$SHA'\033[0m" | |
| echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk/$SHA'\033[0m" |
Prompt to fix with AI
Copy this prompt into your AI coding assistant to fix this issue.
In `scripts/utils/upload-artifact.sh` at line 23, the success echo message uses the staging install URL `https://pkg.stainless.com/s/node-sdk-staging/$SHA`. This file lives in the production repo `hyperspell/node-sdk`, so the URL should be `https://pkg.stainless.com/s/node-sdk/$SHA`. Change `node-sdk-staging` back to `node-sdk` on that line.
Confidence Score: 2/5 - Changes NeededNot safe to merge — while this PR accomplishes the intended goal of syncing generated SDK changes from staging and removing deprecated Key Findings:
Files requiring special attention
|
85b232c to
13f6135
Compare
EntelligenceAI PR SummaryIncrements the MCP server version string from
Confidence Score: 5/5 - Safe to MergeSafe to merge — this PR performs a straightforward version bump in Key Findings:
Files requiring special attention
|
…900219af0acdbe9 BREAKING CHANGE: removes the google_calendar integration endpoints, the slack integration list endpoint, and the box/google_calendar per-source options on memories search. Source: hyperspell/node-sdk-staging@9e250ab Promoted by: https://github.com/hyperspell/hyperspell/actions/runs/29068363046
Promotes the generated SDK from the staging buffer to this production repo.
hyperspell/node-sdk-staging@9e250aba6f6ae8194f242258a900219af0acdbe9(refmain)CHANGELOG.md, release-please manifest/config, the release-please/publish/release-doctor workflows, and version stamps (kept at0.40.0; release-please bumps them on release).Merging hands off to release-please: it will open a release PR computing the next version from this PR's conventional-commit message — that release PR is the human gate for the actual publish. Amend the commit type (
fix:/feat!:) before merging if the change warrants a different bump.A re-dispatch of the promote workflow force-pushes this branch, superseding this PR's content in place.