Skip to content

feat(api)!: sync generated SDK from staging (removes google_calendar + slack list endpoints)#99

Open
aburkard wants to merge 1 commit into
mainfrom
stlc-promote
Open

feat(api)!: sync generated SDK from staging (removes google_calendar + slack list endpoints)#99
aburkard wants to merge 1 commit into
mainfrom
stlc-promote

Conversation

@aburkard

@aburkard aburkard commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Promotes the generated SDK from the staging buffer to this production repo.

  • Source: hyperspell/node-sdk-staging@9e250aba6f6ae8194f242258a900219af0acdbe9 (ref main)
  • Promoted by: https://github.com/hyperspell/hyperspell/actions/runs/29068363046
  • Excluded (production-owned): CHANGELOG.md, release-please manifest/config, the release-please/publish/release-doctor workflows, and version stamps (kept at 0.40.0; release-please bumps them on release).

Merging hands off to release-please: it will open a release PR computing the next version from this PR's conventional-commit message — that release PR is the human gate for the actual publish. Amend the commit type (fix: / feat!:) before merging if the change warrants a different bump.

A re-dispatch of the promote workflow force-pushes this branch, superseding this PR's content in place.

@firetiger-agent

firetiger-agent Bot commented Jul 10, 2026

Copy link
Copy Markdown

Firetiger has created a monitoring plan for this PR.

View monitor

@aburkard aburkard changed the title feat(api): sync generated SDK from staging feat(api)!: sync generated SDK from staging (removes google_calendar endpoints) Jul 10, 2026
Comment thread packages/mcp-server/src/server.ts Outdated
Comment thread scripts/utils/upload-artifact.sh Outdated
if echo "$UPLOAD_RESPONSE" | grep -q "HTTP/[0-9.]* 200"; then
echo -e "\033[32mUploaded build to Stainless storage.\033[0m"
echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk/$SHA'\033[0m"
echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk-staging/$SHA'\033[0m"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR BUG Success message points to staging install URL in production repo

The artifact is uploaded via $SIGNED_URL (production-signed), but the printed install URL references node-sdk-staging instead of node-sdk. A developer following this output would install the staging package, not the artifact just uploaded to production storage.

Suggested change
echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk-staging/$SHA'\033[0m"
echo -e "\033[32mInstallation: npm install 'https://pkg.stainless.com/s/node-sdk/$SHA'\033[0m"
Prompt to fix with AI

Copy this prompt into your AI coding assistant to fix this issue.

In `scripts/utils/upload-artifact.sh` at line 23, the success echo message uses the staging install URL `https://pkg.stainless.com/s/node-sdk-staging/$SHA`. This file lives in the production repo `hyperspell/node-sdk`, so the URL should be `https://pkg.stainless.com/s/node-sdk/$SHA`. Change `node-sdk-staging` back to `node-sdk` on that line.

@entelligence-ai-pr-reviews

Copy link
Copy Markdown

Confidence Score: 2/5 - Changes Needed

Not safe to merge — while this PR accomplishes the intended goal of syncing generated SDK changes from staging and removing deprecated google_calendar endpoints, it introduces two significant bugs that need resolution before merging. In packages/mcp-server/src/server.ts, the McpServer version was reset to hardcoded 0.0.1 instead of dynamically tracking the package version, which will break version reporting for all downstream consumers. Additionally, in scripts/utils/upload-artifact.sh, the success message prints a staging install URL (referencing now) despite the artifact being uploaded via a production-signed $SIGNED_URL, which will mislead operators into installing from the wrong environment.

Key Findings:

  • In packages/mcp-server/src/server.ts, the McpServer instantiation hardcodes version 0.0.1 instead of reading from the package manifest, effectively stripping version identity from the MCP server and breaking any tooling or clients that rely on version negotiation or reporting.
  • In scripts/utils/upload-artifact.sh, the printed success/install URL references a staging endpoint (now) while the actual upload target is production (via $SIGNED_URL), creating an operational hazard where engineers following the printed URL would install a different artifact than the one just uploaded.
  • The PR's core intent — removing google_calendar endpoints from the generated SDK to match staging — is a straightforward sync operation, but the incidental changes to versioning and deployment scripts introduce correctness and operational bugs unrelated to the feature removal.
Files requiring special attention
  • packages/mcp-server/src/server.ts
  • scripts/utils/upload-artifact.sh

@aburkard aburkard force-pushed the stlc-promote branch 2 times, most recently from 85b232c to 13f6135 Compare July 10, 2026 04:10
@entelligence-ai-pr-reviews

Copy link
Copy Markdown

EntelligenceAI PR Summary

Increments the MCP server version string from 0.39.0 to 0.40.0.

  • Version updated in the McpServer configuration object inside newMcpServer in packages/mcp-server/src/server.ts
  • No functional or logic changes; version bump only

Confidence Score: 5/5 - Safe to Merge

Safe to merge — this PR performs a straightforward version bump in packages/mcp-server/src/server.ts, incrementing the McpServer version string from 0.39.0 to 0.40.0 inside the newMcpServer configuration object. The change is purely cosmetic with zero runtime logic impact, no new code paths introduced, and no review comments were generated by the automated analysis. The PR title accurately describes the breaking-change nature of removing google_calendar endpoints in the broader SDK sync, though the actual diff reviewed here is limited to the version string update.

Key Findings:

  • The only change in packages/mcp-server/src/server.ts is a single-line version string update from 0.39.0 to 0.40.0, which carries no runtime risk.
  • No review comments, critical issues, or logic concerns were identified across the 23 reviewed files, and zero pre-existing unresolved comments exist.
  • The PR correctly signals a breaking change via the ! in the conventional commit title (feat(api)!), appropriately communicating the removal of google_calendar endpoints to consumers.
Files requiring special attention
  • packages/mcp-server/src/server.ts

@aburkard aburkard changed the title feat(api)!: sync generated SDK from staging (removes google_calendar endpoints) feat(api)!: sync generated SDK from staging (removes google_calendar + slack list endpoints) Jul 10, 2026
…900219af0acdbe9

BREAKING CHANGE: removes the google_calendar integration endpoints, the slack integration list endpoint, and the box/google_calendar per-source options on memories search.

Source: hyperspell/node-sdk-staging@9e250ab

Promoted by: https://github.com/hyperspell/hyperspell/actions/runs/29068363046
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant