Skip to content

fix(gates): gate on the DEED grammar, per the template and standards#837 - #141

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/deed-gate-grammar
Sep 21, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/deed-gate-grammar

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Why

The guard in dogfood-gate.yml counted .a2ml files only:

COUNT=$(find . -name '*.a2ml' -not -path './.git/*' | wc -l)

so a repo whose manifest is written in the current grammar is reported as having none, and the
summary/compliance row is skipped by the same predicate (if find . -name '*.a2ml' ... | grep -q .).
The validator itself has scanned both grammars for a while -- the caller's predicate is the bug.

Authority

  • rsr-template-repo/.github/workflows/deed-validate.yml (the mint source) is what this wording is
    copied from, byte for byte, including -type f-free find and the dual-accept stance.
  • standards#837 — "DEED conversion campaign", campaign step 4: *"flip ... RSR gates from .a2ml
    presence to .deed presence alongside". Gate predicates, not document contents.
  • deed-ecosystem/README.adoc: "The DEED format name and .deed extension are final, not A2ML."

Deliberately not done

  • No .a2ml file is translated or renamed. #837 makes classification into the four DEED forms and
    per-family mapping specs a prerequisite for mass translation; that is not this PR.
  • No gate that reads a retained file is touched (CLAIMS.a2ml, .machine_readable/Debtfile.a2ml,
    contractiles/INDEX.a2ml); rewriting those would fail gates that currently pass.
  • No job-id or shell-var renames (a2ml-validate, A2ML_COUNT): they are referenced from needs:
    and ${{ needs.*.outputs }}. The Checks-UI label is updated, as it has no references.

Estate-wide .deed gate convergence, 2026-09-21. Script: estate-audit/engine/deed_gate_migration.py.

Mirrors `rsr-template-repo/.github/workflows/deed-validate.yml` and standards#837 step 4. No
`.a2ml` document is translated and no retained-input gate is touched.
@coderabbitai

coderabbitai Bot commented Sep 21, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 097c752a-bf03-412b-b774-5f4409e57965

📥 Commits

Reviewing files that changed from the base of the PR and between 5e68692 and 4e11c08.

📒 Files selected for processing (1)
  • .github/workflows/dogfood-gate.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (30)
  • GitHub Check: scan / gitleaks
  • GitHub Check: scan / shell-secrets
  • GitHub Check: scan / rust-secrets
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Security policy checks
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: analyze (actions, none)
  • GitHub Check: docs
  • GitHub Check: Validate DEED manifests
  • GitHub Check: Runtime Policy
  • GitHub Check: lint
  • GitHub Check: Validate K9 contracts
  • GitHub Check: Groove manifest check
  • GitHub Check: check
  • GitHub Check: check
  • GitHub Check: Empty-linter (invisible characters)
  • GitHub Check: antipattern-check
  • GitHub Check: lint-workflows
  • GitHub Check: lint-workflows
🔇 Additional comments (1)
.github/workflows/dogfood-gate.yml (1)

26-26: LGTM!

Also applies to: 36-36, 39-39, 56-56, 58-58, 63-63, 105-105, 256-256, 302-302


📝 Summary

Summary by CodeRabbit

  • New Features

    • Repository validation now recognises .deed files alongside legacy .a2ml manifests.
    • Dogfood scorecards now include .deed files when checking repository compliance.
  • Improvements

    • Validation and scorecard messages now use clearer DEED and K9 terminology.
    • Updated summaries and warnings provide more accurate guidance when manifests or contracts are missing.

Walkthrough

The dogfood workflow now recognises .deed files as manifests alongside legacy .a2ml files. It updates validation messages, scorecard detection, scorecard labels, and an unrelated K9 contract warning.

Changes

DEED manifest validation

Layer / File(s) Summary
Manifest validation and scorecard updates
.github/workflows/dogfood-gate.yml
The workflow detects .deed and .a2ml files, reports repo deed requirements, updates the validation job name, and corrects K9 contract wording. The scorecard detects .deed files and labels the entry as a DEED repo deed.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: metadatastician

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: updating the gates to use the DEED grammar. It is concise and relevant.
Description check ✅ Passed The description explains the .deed and .a2ml detection change, its authority, and the deliberate scope limits. It directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the deed in place
.deed files join the race
Old .a2ml paths remain
K9 warnings speak plain
The scorecard hops ahead gracely

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath merged commit 25e2bd2 into main Sep 21, 2026
32 of 34 checks passed
@hyperpolymath
hyperpolymath deleted the fix/deed-gate-grammar branch September 21, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant