Skip to content

Tier-S: #41 sub — 28 TODO markers by hot-spot file (per-file PR) #88

Closed

Description

@hyperpolymath

Scope (sub-issue of #41 Phase 3)

Triage and resolve 28 TODO markers in production Rust code by file.

TODO hot-spots

File Count Type
src/functions.rs 6 Function-definition feature incomplete (nesting) — CLAUDE.md flags this
tests/security_tests.rs 4 Test-side TODOs (consider whether to file as new tests or close)
src/parser.rs 4 Parser edges (heredoc, extended-test)
src/external.rs 2
src/audit_log.rs 2 Stub-completion follow-ups from PR #72
Other (10) 10 Scattered

Resolution

Per-file PR. Each TODO either:

  1. Gets resolved (TODO removed, code added)
  2. Gets converted to a // tracked under #N reference and a new issue filed
  3. Gets deleted as obsolete

References

Activity

  1. hyperpolymath commented on Jul 7, 2026

    @hyperpolymath
    OwnerAuthor

    Verified against current impl/rust-cli/src/ (2026-07-07) — rescope 28 → ~8

    Live // TODO markers in src/ (no FIXME, XXX, todo!(), or unimplemented!() exist anywhere):

    • audit_log.rs:78 — Add HMAC signing
    • audit_log.rs:303 — Implement HMAC verification
    • history.rs:6 — history export/statistics/undo-path
    • external.rs:681 — job state via SIGCHLD handler
    • parser.rs:1059 — operators in Task fix(ci): set-e safe counter increments + lean4→lean prover name #40
    • parser.rs:1228 — detect & in pipeline
    • parser.rs:2256 — assignment needs mutable state
    • parser.rs:3025 — UntilLoop variant (currently aliases WhileLoop)

    ~8 markers, not 28. Note several are feature-stubs that overlap other lanes (SIGCHLD → job-control/POSIX lane; assignment/operators → POSIX word-handling), so a chunk of this is really "tracked elsewhere" rather than standalone TODO cleanup.

    🤖 Generated with Claude Code

  2. hyperpolymath commented on Aug 24, 2026

    @hyperpolymath
    OwnerAuthor

    The closure work is now in #193.

    The scoped Rust source and tests contain no remaining TODO, FIXME, HACK, or XXX markers. Residual behavior was not hidden by deleting markers; it has been split into durable successors as required by this issue's resolution contract:

    #193 also removes the remaining false TODO debt markers and updates every former circular #88 reference to its actual successor. It is configured to close this issue on merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions