Repository navigation
rsr: declare the capabilities and remove the vestigial modules (WO 3.2) - #75
Merged
Merged
Conversation
Declare agda, formal-proofs, bash, docs-site, governance-tier and reproducible-build in (rsr-profile :capabilities). Remove the seven modules the canon checker reported as vestigial: src/interface/, benches/, build/container/Containerfile, rust-ci.yml and release.yml, with their actions.lock records, the bench-check recipe and the bench lane test. Port the validate-rsr seam block from rsr-template-repo (re-converge with upstream): the Idris2/Zig seam is required only when src/interface/ exists. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZomaRdNhtZ12Bx8KZi
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
tests/ffi_strings_test.sh copied src/interface/ffi, which WO 3.2 removed. CI has zig, so the proven-suite lane failed. Remove the test and its call in tests/proven_suite_test.sh. Record both in (variant (paths)). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZomaRdNhtZ12Bx8KZi
|
hyperpolymath
marked this pull request as ready for review
November 11, 2026 17:01
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Work order WO 3.2 (ruling D-3 (a)).
agda,formal-proofs,bash,docs-site,governance-tierandreproducible-buildin(rsr-profile :capabilities), written withscripts/deed-clause.sh.src/interface/(ffi, Abi, generated,abi.ipkg, README),benches/,build/container/Containerfile,.github/workflows/rust-ci.yml,.github/workflows/release.yml.actions.lockrecords (and the four dependency records they orphaned), thebench-checkrecipe, the template-bench part oftests/run_proven_suite_test.sh, thesrc/interfacedirectory clause and the Containerfile file entry in the deed(ply).build/just/validate.justis now the template's file (rsr-template-repo main). The seam is required only whensrc/interface/exists (template fb4f67e). No local variant, no template issue opened.scripts/run-proven-suite.sh: the Zig lane skips whensrc/interface/ffiis absent.--require-zigstill fails without zig.(variant (paths))::removedlists the removed paths.:divergedlists the four files changed locally.CLAUDE.md(no change), coapt receipt,docs/architecture/REPOSITORY-MAP.adoc.Owner decision
rust-ci.ymlwas the only CI that rantests/workflows/archetype_lock_merge_test.shand compiledscripts/*.rs. The owner chose to remove it (selector answer: remove).merge-actions-lock.rsis used by the mint recipe and now has no CI check. The other two Rust tools are still tested bymint_cleanup_test.shinestate-rules.yml.Required contexts
scripts/check-required-contexts.shpasses. The only required context isscan / gitleaks(secret-scanner.yml), which is untouched. No removed job is required.Results observed in this session
just 1.56.0 and Nickel 1.18.0 came from release archives. The just archive matched the SHA-256 in
mise.lock. The Nickel binary matched 9cba4dd6...8318cb.check-rsr-profile.shjust validate-rsrSTANDARDS_DIR=<standards> bash .github/hooks/validate-deed.sh)just validate-statejust validate-claude-mdjust validate-coaptjust validate-repo-mapjust census-testtests/workflows/deed_clause_test.shscripts/check-lock-sync.shtests/run_proven_suite_test.sh,tests/proven_suite_test.sh(130 passed),validate_workflows_test.sh,container_kyaml_test.sh,runtime_policy_fold_test.sh,squabble_gate_test.sh,check_root_shape_test.shNot run:
just check-proofs(no Guix and no provers in this container; CI only). Other CI workflows were not run locally.Left in place on purpose (doctrine 7)
scripts/check-bench-regression.sh,compute-bench-baseline.sh,bench-stats.jq: the checker did not name them, andtests/proven_suite_test.shtests them on their own.build/container/(compose, stapeln).compose.yamlstill namesbuild/container/Containerfileas its dockerfile. The owner may want to remove or fix that.verification/proofs/idris2/andtlaplus/(WO 4.1). The Idris2ABIdirectory there is the template example proof. The ABI-1 to ABI-5 obligations inPROOF-NEEDS.adocandPROOF-STATUS.adocwere not removed: they belong to those example proofs, not only to the removed seam. Please decide in WO 3.4 or 4.1..machine_readable/configs/eclexiaiser.tomlsources,scripts/validate-template.sh,docs/developer/ABI-FFI-README.adoc,.cursorrulesand similar agent files,docs/status/TEST-NEEDS.adoc, theZigentry in the deed's:allowedlist, and.hypatia-ignore.validate.justnow also carries the template's two other upstream changes (canonical-name check, closed phase and level sets). They pass here.Generated by Claude Code