Skip to content

fix(ci): repair the permissions block indentation (invalid YAML) - #34

Merged
hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation
Sep 21, 2026
Merged

hyperpolymath merged 2 commits into
mainfrom
fix/ci-permissions-indentation

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

The permissions: block added by the caller-permission campaign was indented one level too deep (appended at job-child indent + 2), which makes the whole workflow file invalid YAML (mapping values are not allowed here) and stops the workflow loading at all. This dedents the block to job-key level — keeping the grants — and validates the file parses before committing.

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Understand this PR’s impact

Explore downstream dependencies and potential security impact with Blast Radius.

View blast radius →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 7a47463c-0149-4c01-81f9-2a036a831102

📥 Commits

Reviewing files that changed from the base of the PR and between 927875c and 8dc0943.

📒 Files selected for processing (2)
  • .github/workflows/governance.yml
  • .github/workflows/secret-scanner.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
⏰ Context from checks skipped due to timeout. (18)
  • GitHub Check: governance / Code quality + docs
  • GitHub Check: governance / Actions lockfile verify
  • GitHub Check: governance / Debt ratchet
  • GitHub Check: governance / Trusted-base reduction policy
  • GitHub Check: governance / Guix packaging policy (Nix retired)
  • GitHub Check: governance / Allowlist Preflight
  • GitHub Check: governance / Licence consistency
  • GitHub Check: governance / Live Actions policy (credentialed advisory)
  • GitHub Check: governance / Exemption ratchet
  • GitHub Check: governance / Well-Known (RFC 9116 + RSR)
  • GitHub Check: governance / Language / package anti-pattern policy
  • GitHub Check: governance / Workflow security linter
  • GitHub Check: governance / Check Workflow Staleness
  • GitHub Check: governance / Security policy checks
  • GitHub Check: secret-scan / rust-secrets
  • GitHub Check: hypatia / Hypatia Neurosymbolic Analysis
  • GitHub Check: secret-scan / gitleaks
  • GitHub Check: secret-scan / shell-secrets
🔇 Additional comments (2)
.github/workflows/governance.yml (1)

40-43: LGTM!

.github/workflows/secret-scanner.yml (1)

25-28: LGTM!


📝 Summary

Summary by CodeRabbit

  • Chores
    • Updated governance and secret-scanning workflow permissions to use the correct job-level configuration.
    • Preserved read access to actions and repository contents, along with the ability to report security events.
    • Improved workflow configuration consistency and reliability without changing the permissions granted.

Walkthrough

The workflow changes move existing actions, contents, and security-events permissions to the correct job-level declarations in the governance and secret scanner jobs.

Changes

Workflow permissions

Layer / File(s) Summary
Correct job-level permission declarations
.github/workflows/governance.yml, .github/workflows/secret-scanner.yml
The governance and secret-scan jobs now declare actions: read, contents: read, and security-events: write at job level.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: correcting invalid indentation in CI workflow permission blocks.
Description check ✅ Passed The description explains the invalid YAML issue, the indentation fix, preserved permissions, and affected workflow files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the workflow gate
Permissions now sit in the proper place
Read actions, read contents, scan with care
Two jobs follow the same rule
Clean YAML hops through the air

Comment @coderabbitai help to get the list of available commands.

@hyperpolymath
hyperpolymath merged commit 35026ca into main Sep 21, 2026
16 of 20 checks passed
@hyperpolymath
hyperpolymath deleted the fix/ci-permissions-indentation branch September 21, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant