Skip to content

fix(cargo): drop semver build metadata from dependency requirements - #667

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/cargo-semver-metadata
Nov 13, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/cargo-semver-metadata

Conversation

@hyperpolymath

@hyperpolymath hyperpolymath commented Nov 12, 2026 •

Copy link
Copy Markdown
Owner

Cargo ignores build metadata in a version requirement and warns on every build:

warning: version requirement 1.1.2+spec-1.1.0for dependencytoml includes semver metadata which will be ignored

Removed from rhodibot, cipherbot, finishingbot, glambot, panicbot (one-line edit) and seambot: toml = "1.1.2+spec-1.1.0" -> "1.1.2", serde_yaml = "0.9.34+deprecated" -> "0.9.34". No other occurrences in the tree.

Verification (per crate: rhodibot, cipherbot, finishingbot, glambot, panicbot, seambot)

  • cargo build --locked: succeeds; Cargo.lock is untouched (git status shows only the six Cargo.toml files).
  • cargo test --locked: all suites pass in all six crates.
  • The warning is present on main and absent after (checked on rhodibot).

Generated by Claude Code

Summary by CodeRabbit

  • Chores
    • Updated package version specifications across several components. These maintenance changes do not alter end-user functionality or introduce visible changes to the product.

Cargo ignores build metadata in a version requirement and warns on every
build (toml 1.1.2+spec-1.1.0, serde_yaml 0.9.34+deprecated). Remove it from
the six crates that carried it. Resolution is unchanged: Cargo.lock is
untouched and 'cargo build --locked' still succeeds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZkERqsQWMogHRpM2z8
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

Six bot manifests remove version metadata suffixes from toml requirements. The finishingbot and glambot manifests also remove a suffix from serde_yaml. The base version numbers remain unchanged.

Changes: Bot dependency specifications

Layer / File(s) Summary
Update dependency version requirements
bots/cipherbot/Cargo.toml, bots/finishingbot/Cargo.toml, bots/glambot/Cargo.toml, bots/panicbot/Cargo.toml, bots/rhodibot/Cargo.toml, bots/seambot/Cargo.toml
The manifests remove +spec-1.1.0 from toml requirements. The finishingbot and glambot manifests also remove +deprecated from serde_yaml requirements.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: Minimal · up to e262c

This change removes a Cargo warning about ignored build metadata in dependency requirements. It does not change which dependency versions are resolved, so there is no expected runtime or build impact.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@sonarqubecloud

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath marked this pull request as ready for review November 13, 2026 11:03
@hyperpolymath
hyperpolymath merged commit c32fc04 into main Nov 13, 2026
65 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins.

@hyperpolymath
hyperpolymath deleted the fix/cargo-semver-metadata branch November 13, 2026 11:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T11:05:04.736503Z e262cb1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

hyperpolymath pushed a commit that referenced this pull request Nov 13, 2026
Resolves conflicts with #667/#668/#670: every finding names a file (#668)
while SCM-001/MACH-007 stay retired, git-seo reports as skipped, and
fleet-report-back keeps skip reasons beside the adapter exit-status guard
and the unpathed-finding warning. Drops default() on unit structs in the
new finishingbot scope test so clippy stays clean.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZkERqsQWMogHRpM2z8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants