Repository navigation
fix(cargo): drop semver build metadata from dependency requirements - #667
Conversation
Cargo ignores build metadata in a version requirement and warns on every build (toml 1.1.2+spec-1.1.0, serde_yaml 0.9.34+deprecated). Remove it from the six crates that carried it. Resolution is unchanged: Cargo.lock is untouched and 'cargo build --locked' still succeeds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZkERqsQWMogHRpM2z8
|
Caution Review failedThe pull request is closed. Walkthrough
Merge Risk:
|
|
|
This security review couldn’t start because the paying account has exhausted its Codex allowance and has insufficient available credits. The payer can check their balance and add credits in the Codex usage dashboard, then try again. If you do not manage the paying account, contact this repository's admins. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Resolves conflicts with #667/#668/#670: every finding names a file (#668) while SCM-001/MACH-007 stay retired, git-seo reports as skipped, and fleet-report-back keeps skip reasons beside the adapter exit-status guard and the unpathed-finding warning. Drops default() on unit structs in the new finishingbot scope test so clippy stays clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZkERqsQWMogHRpM2z8



Cargo ignores build metadata in a version requirement and warns on every build:
warning: version requirement1.1.2+spec-1.1.0for dependencytomlincludes semver metadata which will be ignoredRemoved from rhodibot, cipherbot, finishingbot, glambot, panicbot (one-line edit) and seambot:
toml = "1.1.2+spec-1.1.0"->"1.1.2",serde_yaml = "0.9.34+deprecated"->"0.9.34". No other occurrences in the tree.Verification (per crate: rhodibot, cipherbot, finishingbot, glambot, panicbot, seambot)
cargo build --locked: succeeds; Cargo.lock is untouched (git statusshows only the six Cargo.toml files).cargo test --locked: all suites pass in all six crates.Generated by Claude Code
Summary by CodeRabbit