fix(launcher): restore the AGPL-3.0-or-later header lost in the #102 realign - #105
Merged
Merged
Conversation
…realign game-server-admin#102 (6152bda) realigned the launcher with a generator that hard-coded `SPDX-License-Identifier: MPL-2.0` (twice) and ignored `[project].license`, silently relicensing the launcher against this repo's docs/legal/LICENSE-POLICY.adoc (code -> AGPL-3.0-or-later, #62/309accc). - game-server-admin.launcher.a2ml: `[project].license` = AGPL-3.0-or-later (the app's licence). The file's own SPDX header stays MPL-2.0 per the config carve-out. - game-server-admin-launcher.sh: re-realigned with launch-scaffolder#64 (1ddf146), which emits the project licence once. Diff is the header only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 12 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 Hypatia Security ScanFindings: 85 issues detected
View findings[
{
"reason": "Job `triage` in label-triage.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
"type": "missing_timeout_minutes",
"file": "label-triage.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium",
"recipe_id": "recipe-add-workflow-timeout-minutes",
"job": "triage"
},
{
"reason": "Job `sync` in labels.yml has no `timeout-minutes:` declaration. Default is 6 hours — a stuck codeload fetch or runner hang can burn budget. Add `timeout-minutes: 10` (or proportional).",
"type": "missing_timeout_minutes",
"file": "labels.yml",
"action": "flag",
"rule_module": "workflow_audit",
"severity": "medium",
"recipe_id": "recipe-add-workflow-timeout-minutes",
"job": "sync"
},
{
"line": 39,
"reason": "job in .github/workflows/labels.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/labels.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 45,
"reason": "job in .github/workflows/push-email-notify.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/push-email-notify.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 120,
"reason": "job in .github/workflows/release.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/release.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 25,
"reason": "job in .github/workflows/instant-sync.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/instant-sync.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 84,
"reason": "job in .github/workflows/hypatia-scan.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/hypatia-scan.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 24,
"reason": "job in .github/workflows/boj-build.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/boj-build.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 53,
"reason": "job in .github/workflows/label-triage.yml references `secrets.*` but does not install `step-security/harden-runner` — review outbound-egress monitoring",
"type": "RE001",
"file": ".github/workflows/label-triage.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
},
{
"line": 87,
"reason": "workflow .github/workflows/static-analysis-gate.yml:87 step `Emit check annotations` swallows non-zero exit via `|| true` — failures will be masked",
"type": "RE005",
"file": ".github/workflows/static-analysis-gate.yml",
"action": "report",
"rule_module": "research_extensions",
"severity": "warn"
}
]Powered by Hypatia Neurosymbolic CI/CD Intelligence |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores
game-server-admin-launcher.sh's AGPL-3.0-or-later header, which #102 (6152bda, merged 2026-09-30) replaced with twoMPL-2.0lines.Why
docs/legal/LICENSE-POLICY.adoc(#62, 309accc) puts code — including.sh— under AGPL-3.0-or-later and keeps config under an MPL-2.0 carve-out. #102's realign used a launch-scaffolder generator that hard-codedMPL-2.0and never read[project].license, so it relicensed a shipped file without anyone deciding to. That generator defect is fixed in hyperpolymath/launch-scaffolder#64.Change
game-server-admin.launcher.a2ml:[project].license = "AGPL-3.0-or-later"(the app's licence). The config file's own SPDX header stays MPL-2.0 per the carve-out.game-server-admin-launcher.sh: re-realigned from launch-scaffolder#64 at 1ddf146. The diff is the header only: oneAGPL-3.0-or-laterscript header, one matching;;deed header, duplicate removed.CONFIG_FILEand the body are byte-identical.bash -nok;shellcheck -S warningclean. No CI here depends on realign, so this can merge before or after launch-scaffolder#64. Until #64 merges, a realign from the old generator would revert this header again.Not armed for automerge: armed PRs on this repo merge on the spot (#104, #102), so this is left for your review.
🤖 Generated with Claude Code
https://claude.ai/code/session_0136eszqrQ53Kj7aBH1D4rXK