Skip to content

fix(deps): resolve RUSTSEC-2026-0414 in the root lockfile - #457

Merged
hyperpolymath merged 1 commit into
mainfrom
fix/audit-pulldown-cmark-0414
Nov 3, 2026
Merged

hyperpolymath merged 1 commit into
mainfrom
fix/audit-pulldown-cmark-0414

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Both cargo-audit jobs on #455 reported the same advisory. Update the root lock entry to 0.13.5 using the crates.io index checksum. The index declares identical dependencies for both versions. Verify hosted Cargo audit and locked build. The fuzz workspace has no pulldown-cmark entry.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 4ad02d50-415b-45b8-a3ae-8ee0f397567e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • No new commits to review - use @coderabbitai full review for a full pass
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T07:20:50.583454Z 1f0cb32 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

@hyperpolymath
hyperpolymath enabled auto-merge (squash) November 2, 2026 21:09
@hyperpolymath
hyperpolymath merged commit 744c86c into main Nov 3, 2026
48 of 49 checks passed
@hyperpolymath
hyperpolymath deleted the fix/audit-pulldown-cmark-0414 branch November 3, 2026 17:46
hyperpolymath added a commit that referenced this pull request Nov 5, 2026
## Summary

`Dependency audit` and `rust-ci / Cargo audit (security)` are red on
`main` and on #458 for **RUSTSEC-2026-0433**: pulldown-cmark 0.13.5,
quadratic parsing of nested image wikilinks (CVSS 7.5, published
2026-10-28). This PR is the separate `fix(deps)` change proposed in
[#458's
comment](#458 (comment)),
in the same shape as #457 (RUSTSEC-2026-0414).

## Changes

- `Cargo.lock`: `pulldown-cmark` 0.13.5 → 0.13.6, via `cargo update -p
pulldown-cmark --precise 0.13.6`. Only that package's `version` and
`checksum` change; no other package moves.
- `pulldown-cmark` is a build dependency only: `echidna-grpc` →
`tonic-prost-build` → `prost-build` (and `pulldown-cmark-to-cmark`). The
`fuzz/` workspace has no `pulldown-cmark` entry, so its lock is
untouched.

## RSR Quality Checklist

### Required

- [x] Tests pass: lockfile-only change, no source change; `echidna-grpc`
(the only dependent) builds with `--locked`
- [x] Code is formatted: no source change
- [x] Linter is clean: no source change
- [x] No banned language patterns
- [x] No `unsafe` blocks: not applicable
- [x] No banned functions: not applicable
- [x] SPDX license headers present: no new files
- [x] No secrets, credentials, or `.env` files included

### As Applicable

- [x] New dependencies reviewed for license compatibility: no new
dependency; pulldown-cmark's licence is unchanged at a patch release

## Testing

| Check | Result |
|---|---|
| `cargo audit -f <main's Cargo.lock>` (cargo-audit 0.22.2) |
`RUSTSEC-2026-0433`, **1 vulnerability found**, which reproduces CI |
| `cargo audit -f Cargo.lock` (this branch) | **0 vulnerabilities**; the
2 warnings are already on the repo's allow-list |
| `cargo tree --locked --workspace --all-features --target all -i
pulldown-cmark` | only `prost-build` and `pulldown-cmark-to-cmark`, both
under `echidna-grpc`'s build dependencies |
| `cargo check --locked -p echidna-grpc` (rustc 1.99.0, protoc 3.21.12)
| finished; the build script's protobuf codegen runs on 0.13.6 |
| `git diff --text Cargo.lock` | one package: version and checksum lines
only |

After this merges, #458's two audit failures should clear once its
branch is updated; its other two reds (Guix runner package, gitleaks on
another branch's commit) are explained there and are unrelated.

---
_Generated by [Claude
Code](https://claude.ai/code/session_01KUZiEB43T3E9fJAXqwbSDm)_

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant