Repository navigation
chore: instantiate from the RSR template by hand, keeping project work - #9
Merged
Merged
Conversation
… work) bactrian was cut from hyperpolymath/rsr-template-repo at 889f7f7 but its repo-init mint was never run, leaving rsr-template-repo_chora.deed and unfilled {{TOKEN}} placeholders (OpenSSF Compliance and Canon lockstep failed). The mint was run on a scratch copy and its result applied here; all project files (Bactrian docs, doctor script and test, authorities.lock, dependabot bumps in workflows and actions.lock) are kept byte for byte. - deed renamed to bactrian_chora.deed; identity and clade stay UNASSIGNED - (canon) set to 2.1.5; (provenance) and :parent-pin name the template commit 889f7f7 and tree 0b6f966 - template-only archetypes/julia-library removed with its test and its mint-verbatim entry - CLAUDE.md and docs/architecture/REPOSITORY-MAP.adoc regenerated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136P7ZohGxQnA5cbBZyi8Wp
Contributor
|
Important Review skippedToo many files! This PR contains 142 files, which is 42 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
 |
The negative control in use_template_mint_test.sh deleted archetypes/
and expected the stale map to list it. A minted repo no longer has
archetypes/, so the control could never pass here ("this check is
vacuous"). rsr-template-repo main already fixed this by creating its own
control file; this ports that block unchanged, including the worktree
mode check.
bash tests/e2e/use_template_mint_test.sh: PASS (rc 0).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZohGxQnA5cbBZyi8Wp
Owner
Author
|
CI on b636343, 3 failures:
Generated by Claude Code |
Filling {{SERVICE_NAME}} left quoted keys ("bactrian") that KYAML writes
unquoted, so Estate Rules' "Converted YAML stays KYAML" failed. The
current template's repo-init runs scripts/format-container-kyaml.sh for
exactly this; this repo's older recipe did not. Formatted with the
pinned standards kyaml-format.sh (75bd599, sha256 5fddd58f...) and yq
4.53.3, as CI uses. Only 3 keys change; values are unchanged.
kyaml-format.sh --check on the 3 converted files: all KYAML.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0136P7ZohGxQnA5cbBZyi8Wp
|
hyperpolymath
marked this pull request as ready for review
November 12, 2026 16:18
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bactrian was created from
rsr-template-repo, but its repo-init (mint) never ran. It still hadrsr-template-repo_chora.deedand about 100 files with{{TOKEN}}placeholders, so OpenSSF Compliance and Canon lockstep failed.The owner chose "hand-instantiate, keep the work" (selector, 2026-11-12). The mint ran only in a scratch copy. The branch takes its result only for files that are still pure template files. This follows hyperpolymath/sholes#7, which came from the same template era and passed all 37 CI checks.
Changes
889f7f79(tree0b6f9661).(provenance)and:parent-pinname that commit..machine_readable/bactrian/authorities.lockscripts/bactrian/doctor.shand its testdocs/README.adocbactrian_chora.deed. Thebuild/docs-seedpages move todocs/.archetypes/andbuild/templates/are deleted.(canon)is 2.1.5. Identity and clade stay UNASSIGNED.tests/workflows/julia_library_test.shis deleted, because it tests the deleted julia archetype. Its entry is removed from.machine_readable/mint-verbatim.txt, because the stale entry failednon_interactive_mint_test.sh.CLAUDE.mdand the repository map are regenerated.RSR Quality Checklist
Required
As Applicable
Testing
Run locally after
git add -A. These pass:scripts/check-no-placeholders.shscripts/check-lock-sync.shjust verifyjust validate-claude-mdscripts/check-adoc-renders.sh(161 files)estate-rules.yml, except the three below.Not run, or limited by this machine:
tests/e2e/use_template_mint_test.sh:uuidgenis missing here. CI installs it.kyaml_ratchet_test.sh: fails with the same jq error on unmodifiedmain.kyaml-format.sh --checkstep: it needs a script that CI downloads.Open point:
tests/e2e/julia_mint_test.shandjulia_fmt_test.shstill refer to the deleted archetype. No workflow inestate-rules.ymlruns them.Screenshots
Not applicable.
Generated by Claude Code