Skip to content

fix(uninstall): redirect is not valid on a for-list #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hyperpolymath merged 2 commits into from
Sep 4, 2026
Merged

fix(uninstall): redirect is not valid on a for-list #320

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55bddf4
fix(uninstall): redirect is not valid on a for-list
hyperpolymath Aug 26, 2026
130e8dd
Merge branch 'main' into fix/shellcheck-parse-error
hyperpolymath Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/management/uninstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,7 @@ cleanup_cache() {
for cache_path in "${cache_locations[@]}"; do
if [[ "$cache_path" == *"*"* ]]; then
# Glob pattern
for item in $cache_path 2>/dev/null; do
for item in $cache_path; do

@codacy-production codacy-production Bot Aug 26, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 MEDIUM RISK

Expanding $cache_path without quotes causes the shell to perform word splitting. If any directory in the path (such as the user's home directory) contains spaces, the loop will break the path into multiple invalid segments, causing the cleanup to fail. Refactor the cleanup_cache function to safely handle paths with spaces by avoiding unquoted variable expansion for globs (e.g., using shopt -s nullglob).

if [[ -e "$item" ]]; then
log INFO "Removing: $item"

Expand Down
Loading