Repository navigation
Conversation
Signed-off-by: Ludvig Liljenberg <4257730+ludfjig@users.noreply.github.com>
ludfjig
added
area/documentation
ludfjig
requested review from
andreiltd,
danbugs,
dblnz,
devigned,
jprendes,
jsturtevant,
simongdavies,
squillace and
syntactically
as code owners
October 29, 2026 23:34
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The proposal leaves handling of events larger than 4 KiB undefined and omits the snapshot ABI bump and regeneration requirements needed to prevent incompatible snapshots from being resumed.
2 open issues
What changed in this PR
HIP 0008 proposes replacing FlatBuffers with serde and postcard for Hyperlight’s host-guest control messages. This PR contains the design proposal only, not an implementation.
Changes:
- Defines message types, a control-data length field, and trace batching while preserving external byte payloads.
- Describes removing FlatBuffers tooling and generated code.
- Presents preliminary performance results, drawbacks, and alternatives.
| File | Description |
|---|---|
proposals/0008-postcard-serialization/README.md |
Documents the serialization proposal, wire format, benchmarks, and tradeoffs. |
Review effort: Balanced
Comment on lines
+111
to
+113
| * **Trace batch:** postcard events back to back in one buffer of up to | ||
| 4 KiB. The encoder sends the batch when the next event does not fit, so no | ||
| size estimate is needed. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered