Skip to content

Update cargo-hyperlight version to 0.1.14 - #1754

Merged
yoshuawuyts merged 2 commits into
mainfrom
update-cargo-hl-version
Aug 24, 2026
Merged

Update cargo-hyperlight version to 0.1.14#1754
yoshuawuyts merged 2 commits into
mainfrom
update-cargo-hl-version

Conversation

@yoshuawuyts

@yoshuawuyts yoshuawuyts commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Closes #1749, thanks!

Edit: this PR also adds an automatic update script to automate the cargo-hyperlight update bump. The most complicated part of that was updating the flake.nix files (see #1754 (review) from review), hence the number of changes.

Copilot AI lite review requested due to automatic review settings August 21, 2026 09:24
@yoshuawuyts yoshuawuyts changed the title Update cargo-hyperlight version to 0.14.0 Update cargo-hyperlight version to 0.1.14 Aug 21, 2026
@yoshuawuyts
yoshuawuyts force-pushed the update-cargo-hl-version branch from 1cc935a to 7783617 Compare August 21, 2026 09:26
@yoshuawuyts yoshuawuyts added the area/dependencies Concerns dependencies or related components label Aug 21, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates guest build tooling to use cargo-hyperlight 0.1.14.

Changes:

  • Bumps the Justfile version pin from 0.1.12 to 0.1.14.
  • The Nix flake pin remains at 0.1.14-pre and should be aligned.
Show a summary per file
File Summary
Justfile Updates the cargo-hyperlight version; the Nix pin remains inconsistent.

Review details

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

Comment thread Justfile
Signed-off-by: Yosh <github@yosh.is>
@yoshuawuyts
yoshuawuyts force-pushed the update-cargo-hl-version branch from 7783617 to c7c5444 Compare August 21, 2026 09:28
@yoshuawuyts

Copy link
Copy Markdown
Contributor Author

Oh heh, Copilot review flagged a good issue. I feel like I should probably write a script for that so that updating cargo-hyperlight can be automated. I'll try and get to that later today.

@yoshuawuyts yoshuawuyts added the kind/dependencies For PRs that update dependencies or related components label Aug 21, 2026
Signed-off-by: Yosh <github@yosh.is>
@yoshuawuyts

yoshuawuyts commented Aug 21, 2026

Copy link
Copy Markdown
Contributor Author

@syntactically As the owner of our Nix flake integration, I'm assigning this to you for review.

I'm on macOS and don't have Nix installed, so I relied on AI to write the Nix update script. To get that to work I had it change the flake.nix file to no longer require having a local nix installation and pulling hash information from Crates.io instead. From what I can tell it looks fine, but I have no way of actually testing it right now - so if you could review this that would be great. Thanks!

@ludfjig ludfjig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (no idea about the nix stuff though))

@jprendes jprendes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as @ludfjig , no idea about nix, but otherwise it looks good.
Maybe we split it in 2 PRs, one for the non-nix changes and another one for nix?

@yoshuawuyts

Copy link
Copy Markdown
Contributor Author

Maybe we split it in 2 PRs, one for the non-nix changes and another one for nix?

If the Nix changes end up being incorrect or broken, I'll do that - good suggestion. I'd like to hear from @syntactically first though to see if we can land this outright.

@syntactically syntactically left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoshuawuyts Thank you for thinking of the nix support as a first class citizen! I took a quick look and I think the changes look good, and I did go ahead and test them locally and it seems to work fine.

The change to importCargoLock does mean using import-from-derivation, which can be a problem at large scale but is probably fine here.

to no longer require having a local nix installation

Not sure what you meant by that?

@yoshuawuyts

Copy link
Copy Markdown
Contributor Author

Not sure what you meant by that?

Updating the flake.nix file prior to this file seemed to require access to a local nix(1) install, which I don't have. Apparently the SHA's are computed based on some kind of Nix-specific directory layout.

@yoshuawuyts
yoshuawuyts merged commit fab55ca into main Aug 24, 2026
55 checks passed
@yoshuawuyts
yoshuawuyts deleted the update-cargo-hl-version branch August 24, 2026 16:16
@syntactically

Copy link
Copy Markdown
Member

Updating the flake.nix file prior to this file seemed to require access to a local nix(1) install, which I don't have. Apparently the SHA's are computed based on some kind of Nix-specific directory layout.

Ah, I understand what you meant. Yes, the hash that was in there previously was the hash (via a nix-specific algorithm) of a vendor directory containing downloaded copies of all the dependencies, which is probably a pain to compute the correct thing for without nix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependencies Concerns dependencies or related components kind/dependencies For PRs that update dependencies or related components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS tests depend on unreleased cargo-hyperlight version

5 participants