Update cargo-hyperlight version to 0.1.14 - #1754
Conversation
1cc935a to
7783617
Compare
There was a problem hiding this comment.
Pull request overview
Updates guest build tooling to use cargo-hyperlight 0.1.14.
Changes:
- Bumps the
Justfileversion pin from 0.1.12 to 0.1.14. - The Nix flake pin remains at 0.1.14-pre and should be aligned.
Show a summary per file
| File | Summary |
|---|---|
Justfile |
Updates the cargo-hyperlight version; the Nix pin remains inconsistent. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
Signed-off-by: Yosh <github@yosh.is>
7783617 to
c7c5444
Compare
|
Oh heh, Copilot review flagged a good issue. I feel like I should probably write a script for that so that updating cargo-hyperlight can be automated. I'll try and get to that later today. |
Signed-off-by: Yosh <github@yosh.is>
|
@syntactically As the owner of our Nix flake integration, I'm assigning this to you for review. I'm on macOS and don't have Nix installed, so I relied on AI to write the Nix update script. To get that to work I had it change the |
ludfjig
left a comment
There was a problem hiding this comment.
lgtm (no idea about the nix stuff though))
If the Nix changes end up being incorrect or broken, I'll do that - good suggestion. I'd like to hear from @syntactically first though to see if we can land this outright. |
syntactically
left a comment
There was a problem hiding this comment.
@yoshuawuyts Thank you for thinking of the nix support as a first class citizen! I took a quick look and I think the changes look good, and I did go ahead and test them locally and it seems to work fine.
The change to importCargoLock does mean using import-from-derivation, which can be a problem at large scale but is probably fine here.
to no longer require having a local
nixinstallation
Not sure what you meant by that?
Updating the |
Ah, I understand what you meant. Yes, the hash that was in there previously was the hash (via a nix-specific algorithm) of a vendor directory containing downloaded copies of all the dependencies, which is probably a pain to compute the correct thing for without nix. |
Closes #1749, thanks!
Edit: this PR also adds an automatic update script to automate the
cargo-hyperlightupdate bump. The most complicated part of that was updating theflake.nixfiles (see #1754 (review) from review), hence the number of changes.