Repository navigation
Remove the requests of an in-flight proposal from the pool once it is decided - #702
Merged
Merged
Conversation
Contributor
|
@HagarMeir Please fulfill the dco condition |
When a view change commits an in-flight proposal, the view that decides it had no requests and no pre-prepare time. So its requests were never removed from the request pool (their timers kept running, leading to forwarding and complaints), CountTxsAll was not increased, and LatencyBatchProcessing recorded the time since the zero time. Set the in-flight view's requests from the verifier and its pre-prepare time right before it starts, and check both in TestCommitInFlight. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Signed-off-by: Hagar Meir <hagar.meir@ibm.com>
HagarMeir
force-pushed
the
fix/inflight-view-requests
branch
from
October 15, 2026 10:08
52f4a26 to
9ea3d07
Compare
pfi79
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic's AI assistant) on behalf of Hagar Meir.
Fixes #701.
When a view change commits an in-flight proposal, the temporary view that decides it is not set up like a regular view:
CountTxsAllis not increased;LatencyBatchProcessingrecords about 292 years.Changes
commitInFlightProposalsets the in-flight view'sinFlightRequestsfromVerifier.RequestsFromProposal. When the proposal is decided,ViewChanger.Decidethen removes them from the pool.commitInFlightProposalsetsbeginPrePrepareright before the in-flight view starts.TestCommitInFlightnow checks that the requests of the decided in-flight proposal are removed, and that a reasonable latency is recorded. Both checks fail without the fix.No message or decision rule changes. Only the local request pool and metrics are affected.
🤖 Generated with Claude Code