Repository navigation
Conversation
Allow chunked framing for HTTP/2 requests serialized as HTTP/1.1. Previously, unknown-length bodies without Content-Length used a zero-length encoder and were silently discarded. Add an integration regression that verifies the HTTP/1.1 version, chunked framing, complete payload, and body termination.
shuvroroy
marked this pull request as ready for review
October 18, 2026 10:10
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An HTTP/2 request sent through an HTTP/1 connection is serialized as HTTP/1.1, but framing only allows chunking for requests originally marked HTTP/1.1. A POST with an unknown-length body and no Content-Length therefore uses a zero-length encoder and silently loses its body.
Allow chunked framing for coerced HTTP/2 requests. The regression sends a two-frame streaming POST through an HTTP/1 client and verifies the received version, chunked framing, complete payload, and body termination.
Validation:
The regression fails before the fix (empty body instead of hello world) and passes afterward.
Existing empty-body coercion test passes.
cargo test --features full: 329 passed, 10 ignored.
cargo clippy --features full -- -D warnings: passed.
Repository-wide rustfmt --check --edition 2021: passed.
cargo check --no-default-features --features client,http1: passed.
The description, docs, and comments (words meant for humans) are written by a human, not by an LLM. (https://seanmonstar.com/micro/20260729-i-want-your-own-words/)