Repository navigation
feat: allow space before first header name in responses (#3285) - #4234
Open
manish-9245 wants to merge 1 commit into
Open
manish-9245 wants to merge 1 commit into
manish-9245 wants to merge 1 commit into
Conversation
Expose httparse allow_space_before_first_header_name as a client builder option, so users can opt into accepting leading whitespace before the first response header for compatibility with browsers. Fixes hyperium#3285.
cratelyn
requested changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3285. Exposes httparse allow_space_before_first_header_name via client Builder as allow_space_before_first_header_name_in_responses (default false), for compatibility with servers/browsers that accept leading whitespace before the first response header. Wires through existing h1 ParserConfig plumbing. Tests: cargo build --features full (ok); cargo test --features full --lib (129 passed, 0 failed); cargo test --features full (lib 129, client 70, server 98, integration 14, doc 14 — all ok); cargo fmt --check (clean).