Repository navigation
fix(http1): always remove content-length if transfer-encoding is sent - #4223
Merged
Merged
Conversation
seanmonstar
force-pushed
the
sean/zvmpwqrpulvs
branch
from
October 5, 2026 19:42
f834148 to
a5a02ec
Compare
seanmonstar
force-pushed
the
sean/zvmpwqrpulvs
branch
from
October 5, 2026 19:57
a5a02ec to
5c442cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a request is sent with both
transfer-encodingandcontent-lengthheaders, we try to repair that for the user. (We try to help, but they are more responsible of course.)In some case, if they included both, but the
content-lengthheader was otherwise invalid, we did not remove it. It was sent in its broken state. This changes it to simply always delete acontent-lengthheader if the user also asked to send atransfer-encodingheader.