fix(proxy): stop SOCKS5 optimistic sending deadlock - #310
Merged
Conversation
seanmonstar
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the "optimistic sending" mode, if all of the servers responses are received in a single
readcall,read_message()will hang waiting for more bytes that will never arrive. I've not yet found a server that does this, but best to be safe.Solution is to try to parse from the existing buffer of bytes before trying to read more from the network. We can add an
if !buf.is_empty()gate to prevent callingtry_fromwith an empty buffer, but I don't think it's necessary.First commit adds tests (one of which fails). Second commit makes that test pass.