Repository navigation
docs(vector): drop the engine plugin design and correct internals - #153
Merged
Merged
Conversation
internals.md described a dfe-engine ServicePlugin, ServiceDescriptor and keda_defaults that do not exist. Remove that section and the engine half of the diagram. The app is declared in dfe-infra apps.yaml. Its chart is generated from contract().
- On direct, the bridge dead-letters to the dlq set by scalo DlqConfig. With dlq.enabled false, the record is dropped and counted.
- Wrapper metric names are bare, such as pipeline_ready, transform_vector_lifecycle_state and crashes_total.
- The reload counter's result labels are success, error, rejected and unconfirmed. error and rejected mean the running Vector did not take the change.
- The chart parity table gave StatefulSets and Kafka lag triggers. All three apps are Deployments on scalo-service. None scales on lag.
- The config example uses a broker list and a literal group id. Neither the wrapper nor Vector expands ${VAR}.
- The DFE default scales this app on CPU alone at 70%. scaling_pressure stays 0 while Vector runs.
- default_in names docker-single.
- migration.md describes a generic move from the Vector chart, with no internal repos or paths.
catinspace-au
force-pushed
the
docs/factcheck-c
branch
from
November 12, 2026 06:33
27f4e4e to
84d6b11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
internals.md described a dfe-engine ServicePlugin, ServiceDescriptor and keda_defaults that do not exist. Remove that section and the engine half of the diagram. The app is declared in dfe-infra apps.yaml. Its chart is generated from contract().