Repository navigation
fix(appmgmt): run every fetcher source in one Compose fetcher - #1149
Merged
Merged
Conversation
catinspace-au
force-pushed
the
fix/shared-fetcher
branch
3 times, most recently
from
November 12, 2026 08:38
9c5c476 to
a688412
Compare
A published Compose install runs fixed containers and reads no instance index. Fetcher sources added in the console never ran. - apps.yaml gains shared_instance, and dfe-fetcher declares config.sources. On a docker target, one container runs every instance from dfe-fetcher/fetcher.yaml. instance_id is bound to dfe-fetcher. No index is written. - Source saves compile with their org. Saves and the deploy repo's overlay write check reject instances whose sources clash with a running one or whose org, output or extraEnv differs. Every writer passes that check. - A render keeps running instances and reports new instances it cannot run. It removes the index, instance directories and env files left by a per-instance render. It names each container to remove. - The fetcher's restart paths drop config.sources because reloads now start, stop and rebuild sources. - A per-source app without shared_instance runs one container per source. Where no deployer reads the index, DFE_ENGINE_DEPLOYMENT_HOSTED_INSTANCES names the instances that run. Other sources or instances are rejected with a message naming them and the dfe-docker docs page. - DFE_ENGINE_DEPLOYMENT_APPLY_COMMAND and DFE_ENGINE_DEPLOYMENT_CREDENTIAL_COMMAND hold a deployer's own restart and password commands. Published installs have no Makefile, so make apply and make creds were wrong there. - QueryClient in HTTP mode sends a bearer token or API key, like the dfe CLI. Credentials with a control character are rejected without quoting them. It sent no credentials before, so every auth-enabled engine answered 401. - QueryOptions.store is gone because nothing read it. The API still accepts bodies that send it and ignores the field. - Two comments no longer name an engine HPA or an Argo PostSync hook. - The archiver's default destination moves from /tmp to file:///var/lib/dfe-archiver/archive, where the chart mounts the archive volume.
catinspace-au
force-pushed
the
fix/shared-fetcher
branch
from
November 12, 2026 09:22
a688412 to
ffa55b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A published Compose install runs fixed containers and reads no instance index. Fetcher sources added in the console never ran.