Skip to content

fix(planner): preserve physical column casing in graph scans - #66

Merged
prrao87 merged 1 commit into
mainfrom
codex/fix-column-casing
Oct 27, 2026
Merged

prrao87 merged 1 commit into
mainfrom
codex/fix-column-casing

Conversation

@stugorf

@stugorf stugorf commented Oct 27, 2026

Copy link
Copy Markdown
Member

Problem and change

Queries over fields such as isMarried can fail with a missing lowercase-column error, including queries that do not select that property, because scans project the complete schema.

Bind physical fields with exact Arrow schema names, then apply existing normalized Cypher aliases. Resolve inline filters against the schema spelling through one shared helper, including source nodes, target nodes, relationships and reversed undirected edges.

Refs lance-format/lance-graph#105. This is a lance-csr fix; it does not close the upstream issue.

Validation

  • Failing before on the verified 0.3.1 debug baseline: 104 failed / 26 passed. Passing after: 130 focused cases, 1,393 complete Python tests in both debug and isolated production-wheel verification.
  • Passed: cargo fmt --all --check, cargo test --workspace --locked, workspace Clippy with warnings denied, make install, make test, make lint, executable documentation snippets, strict Zensical build and typos@1.26.0.
  • All three candidate debug gates passed before any final production build. Fresh locked consumers outside the checkouts verified wheel/package payloads and native hashes, then ran each complete suite with Rust absent from PATH.

Mixed-case node IDs, edge endpoints and properties; inline/WHERE filters, target joins, undirected/variable-length traversal, optional nulls, aliases, legacy/join/CSR APIs and native streaming over Arrow/Lance.

Workload Mode Correct queries First-pass geometric speedup
30-query SF1 memory 30 0.989x
30-query SF1 lazy 30 1.035x
IC SF1 memory 14 0.958x
IC SF1 lazy 14 0.971x

Above 1 is faster. These original suite means are retained unchanged; initial >10% per-query flags and their paired investigations are recorded in the final gate record. Both complete workloads preserve the original golden answers. These are local engineering measurements, not an audited SNB result or performance guarantee.

Measured serially after builds stopped, on Apple M4 Max (16 cores, 128 GiB), macOS arm64, Rust 1.96.0 and Python 3.13.17. The suites are pinned at 6260689 (30 queries) and c185123 (IC); settings, dependencies, SF1 manifests, timings and peak process RSS are recorded. Per-query before/after tables, reproduction instructions, and hashed raw evidence provide the commands and receipts.

User impact

Mixed-case Arrow/Lance fields remain unchanged in the source and work through case-insensitive Cypher names. The existing case-sensitivity guide section is updated. No Python signatures, stubs or dependencies change.

Independently based on f5a986e822032a3aa8c52af55ad08e92504ee73c, head e6df15716a052af380e8a5d2da340cc506ecd188. Latest main 6effd0db0c002912cf969fd7447ea7a3ce2631df adds documentation links/package URLs only; runtime sources and locks are unchanged, and this PR applies cleanly. Other platforms and hosted CI are not included in the local verification; check the PR checks for their current status.

Submitted by David Hughes (@stugorf), with AI Collaboration.

Refs lance-format/lance-graph#105. Adapt the focused fix to the current 0.3.1 engine and crate layout.

Submitted by David Hughes (@stugorf), with AI Collaboration.
@prrao87
prrao87 merged commit 7fbf70e into main Oct 27, 2026
8 checks passed
@prrao87
prrao87 deleted the codex/fix-column-casing branch October 27, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants