Repository navigation
fix: stabilize the timed-stream test, fix null ordering and path counts, bump 0.3.1 - #62
Merged
Merged
Conversation
Only the batch holding p.id = 0 fails, and partitions finish in any order, so the first read can succeed. With a release build on a 3-core runner it did 15-25% of the time, failing the v0.3.0 publish. Read until the error surfaces, still failing if the stream ends without it.
ORDER BY always placed nulls first. openCypher orders null after every value, so ascending sorts now put nulls last and descending sorts first. Update the tests that expected the old order and document the rule. Fixes #60
count(v) lowered to count(v__id), which only node and relationship bindings have, so count(DISTINCT p) on a named path and count(x) for UNWIND or WITH values failed to plan. When the aggregate's input has no v__id column but has v, count the value itself. Turn the test that documented the limitation into a correctness test. Fixes #61
Deploying lance-csr with
|
| Latest commit: |
e2b89a6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://66bd0260.lance-csr.pages.dev |
| Branch Preview URL: | https://fix-timed-stream-error-test.lance-csr.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The v0.3.0 PyPI publish stopped at its test job:
test_execution_error_in_a_timed_stream_is_preservedfailed on two of the three macOS runners, so nothing was uploaded. The test assumed the first batch read from the stream would raise the error. Only the batch holdingp.id = 0fails, and partitions finish in any order. With a release build on a 3-core runner, the first read succeeded 15–25% of the time. The engine was correct: across 900 local runs, the error always surfaced and was never lost.This PR fixes the test, adds two quick fixes from the open issues, and bumps the version to 0.3.1 for the PyPI release. crates.io already has 0.3.0; 0.3.1 keeps the crate and package versions aligned.
What changed
ORDER BYputs nulls last in ascending order and first in descending order, as in openCypher. Previously nulls always came first. Tests that had locked in the old order are updated, and the rule is documented. Fixes Ascending ORDER BY sorts nulls first instead of last #60.count(v)works for values without an id column:count(DISTINCT p)on named paths, andcount(x)for UNWIND and WITH values, used to fail to plan. The aggregate now counts the value when there's nov__idcolumn. Parallel edges count as distinct paths. Fixes count(DISTINCT p) fails on named paths #61.Validation
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepass (661 tests). The test that documented thecount(unwind variable)limitation now checks the correct count.python/:make install(0.3.1),make test(1,263 passed) andmake lintpass, anddocs/check_snippets.pyreports no failures.zensical build --strictandtypospass.🤖 Generated with Claude Code