Repository navigation
refactor(paths): name path metadata fields after lance-csr - #57
Merged
Merged
Conversation
Path records stored metadata in __lance_graph_* fields, after the project this repository was forked from. Rename them to __lance_csr_* before 0.3.0 ships, while the change is still free.
Deploying lance-csr with
|
| Latest commit: |
a2cbd5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6e42f128.lance-csr.pages.dev |
| Branch Preview URL: | https://refactor-lance-csr-path-fiel.lance-csr.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Named path values (added in #55) store metadata in fields called
__lance_graph_properties,__lance_graph_identity,__lance_graph_startand__lance_graph_end. They carry the name of the project this repository was forked from. These names are part of the data users see, so changing them after 0.3.0 ships would break anyone reading path records. Renaming them now is free, because they haven't been released yet.What changed
__lance_csr_properties,__lance_csr_identity,__lance_csr_startand__lance_csr_end.No behaviour changes beyond the field names.
Validation
cargo fmt --check,cargo clippy --workspace --all-targets -- -D warningsandcargo test --workspacepass (661 tests).python/:make install,make test(1,247 passed) andmake lintpass, anddocs/check_snippets.pyreports no failures.zensical build --strictandtypospass.🤖 Generated with Claude Code