Repository navigation
refactor(graph): expose read-only mapping accessors - #51
Merged
Merged
Conversation
Migrate mapping readers while keeping public fields for source compatibility until a breaking release. Document migration and test normalized keys and original labels. Part of #23. Implemented with assistance from Codex; runtime and benchmark validation pending.
# Conflicts: # crates/lance-csr-python/src/graph.rs
infer_join_keys now finds relationship mappings case-insensitively, so a relationship variable shared by two joined pattern parts adds its endpoint columns as join keys. Previously the exact lookup missed the lower-cased mapping key and returned no keys.
prrao87
marked this pull request as ready for review
October 26, 2026 16:43
Deploying lance-csr with
|
| Latest commit: |
44f569a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0fd7a4e9.lance-csr.pages.dev |
| Branch Preview URL: | https://codex-issue-23-config-access.lance-csr.pages.dev |
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Adds read-only node/relationship mapping iterators and migrates engine/planner/binding callers to them. Rust users can inspect validated mappings without depending on direct field access. Existing public fields and serialized names remain compatible in this submission; the Rust crate README documents the migration.
Mapping normalization and lookup tests retain the existing builder invariants. Packaging smoke covers the Python API and refresh. This compatible stage does not claim that direct mutation/deserialization can no longer bypass invariants. The private-field and validated-deserialization change is implemented on a separate next-breaking-release branch and remains a closure dependency for#23.
Validation
Head
96598edac33e9c8dab8bf3b0ec1324308faf589e; frozen parent54e02307a48e467a98d9da2183f5adcb767e7c99. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 3 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.Individual review gates pass under the recorded repeat/controlled-investigation rules. Initial failed measurements remain intact in the audit record.
User impact
Adds read-only Rust mapping accessors and migrates internal callers while preserving public fields and serialized names. Migration docs are included. Privacy/validated deserialization remain held for the next breaking release, so #23 stays open.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.