Repository navigation
feat(graph): enforce cooperative query deadlines - #39
Merged
prrao87 merged 9 commits intoOct 26, 2026
Merged
Conversation
Add keyword-only timeout to the three Cypher execution entrypoints. Keep one deadline through streamed reads and release the owned stream while idle; preserve native Arrow reader errors and cooperative traversal cancellation. Issue #19. Submitted by David Hughes (@stugorf), with AI Collaboration. External benchmark runner adoption and performance measurements remain pending.
Drop the owned DataFusion stream when its first error finishes the Arrow reader, preserving the original error. A real CAST failure and Weak reference to a later Arrow batch fail before the fix and pass after it. All 15 native binding tests pass; the Python reader-error regression and complete native rebuild are queued. Submitted by David Hughes (@stugorf), with AI Collaboration.
Refs #19. Preserve bounded cancellation through rejected rows and tombstones while measuring the scheduling trade-off independently.
Member
|
This change merged into an intermediate branch, not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
Relates to #19. Adds keyword-only
timeout=Nonein seconds toCypherEngine.execute,execute_batchesandCypherQuery.execute. One monotonic deadline includes planning and pauses between reads. Zero expires immediately; negative, nonfinite and unrepresentable values raiseValueError.Native
pyarrow.RecordBatchReaderis preserved. Initial expiry raisesTimeoutError; expired reads raiseArrowInvalidwithQuery timeout exceeded. A watchdog releases owned streams during consumer idle time. Close/drop and ordinary errors also release resources. Timed contexts install a private DataFusion join guard, including rejected nested-loop candidates; ordinary contexts remain reusable.Validation
Head
a641cf25cbe34db25245ce2543140af5b735d30e; frozen parent81ef524be83db4abb626394dd4940121a45751e2. Focused checks and regression details record commands, results, documentation and compatibility. The release receipt pins wheel/archive identity and 487 installed tests.Both complete workloads pass unchanged goldens in memory and lazy modes. Retained first-pass geometric mean speedups are below (greater than one is faster). Per-query results and paired investigations remain in the audit archive.
Measurements use the same Apple M4 Max (16 cores, 128 GiB), macOS 26.6.2 arm64 and Python 3.13.17, with Q30 revision
6260689and IC revisionc185123. Reproduction instructions pin settings, data checksums, locks and commands. The frozen main baseline is code-identical to current main90114f3; the equivalence check also verifies clean prospective main-target merges.This is a coordinated draft. Preserve its frozen-head outcomes and apply the shared corrections in the qualified integration; changing the actual target requires requalification. The accepted combined engine source is
7d2ef3e; its current-main documentation merge is5fe24cd.The standalone 8,192-work budget passes its own gates, including the fixed-size IC6 investigation. The combined target retains the tested 1,024-work bound and matching tests after rejecting the larger-budget combined variant. External runner adoption remains outside this submission; keep #19 open.
User impact
execute, execute_batches and CypherQuery.execute gain keyword-only timeout=None in seconds. Initial expiry raises TimeoutError; stream expiry raises ArrowInvalid with Query timeout exceeded. Native readers remain. API docs, stubs and examples cover cooperative limits; external runner adoption remains open.
Review ledger · Current contribution guide
Audit archive: 47,675,190 bytes; SHA-256
b3486fb30a34639c830b5d49353b3838f96369f95df959ac35f85511f7f8b2de. The small current-main supplement preserves the documentation update. Original absolute paths in receipts map to included records through the archive index.Submitted by David Hughes (@stugorf), with AI Collaboration.